Fix phpstan/phpstan#13023: function.alreadyNarrowedType and function.impossibleType after updates to 2.1.15

src/Rules/Comparison/ImpossibleCheckTypeHelper.php

@@ -310,6 +310,11 @@ public function findSpecifiedType(
 				continue;
 			}
 
+			if ($scope->isInTrait() && self::isExpressionDependentOnThis($sureType[0])) {
+				$results[] = TrinaryLogic::createMaybe();
+				continue;
+			}
+
 			if ($this->treatPhpDocTypesAsCertain) {
 				$argumentType = $scope->getType($sureType[0]);
 			} else {
@@ -336,6 +341,11 @@ public function findSpecifiedType(
 				continue;
 			}
 
+			if ($scope->isInTrait() && self::isExpressionDependentOnThis($sureNotType[0])) {
+				$results[] = TrinaryLogic::createMaybe();
+				continue;
+			}
+
 			if ($this->treatPhpDocTypesAsCertain) {
 				$argumentType = $scope->getType($sureNotType[0]);
 			} else {
@@ -381,6 +391,23 @@ private static function isSpecified(Scope $scope, Expr $node, Expr $expr): bool
 		) && $scope->hasExpressionType($expr)->yes();
 	}
 
+	private static function isExpressionDependentOnThis(Expr $expr): bool
+	{
+		if ($expr instanceof Expr\Variable && $expr->name === 'this') {
+			return true;
+		}
+
+		if ($expr instanceof Expr\PropertyFetch) {
+			return self::isExpressionDependentOnThis($expr->var);
+		}
+
+		if ($expr instanceof Expr\MethodCall) {
+			return self::isExpressionDependentOnThis($expr->var);
+		}
+
+		return false;
+	}
+
 	/**
 	 * @param Node\Arg[] $args
 	 */

tests/PHPStan/Rules/Comparison/ImpossibleCheckTypeFunctionCallRuleTest.php

@@ -1207,4 +1207,10 @@ public function testBug13799(): void
 		]);
 	}
 
+	public function testBug13023(): void
+	{
+		$this->treatPhpDocTypesAsCertain = true;
+		$this->analyse([__DIR__ . '/data/bug-13023.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Comparison/data/bug-13023.php

@@ -0,0 +1,52 @@
+<?php declare(strict_types = 1);
+
+namespace Bug13023;
+
+class SomeClass
+{
+	use MyTrait;
+}
+
+class SomeClass2
+{
+	use MyTrait;
+}
+
+trait MyTrait
+{
+	public function getRandom(): int
+	{
+		$value = random_int(1, 100);
+		if (is_a($this, SomeClass::class)) {
+			return $value * $value;
+		}
+		return $value;
+	}
+}
+
+class SomeClass3
+{
+	use MyTrait2;
+
+	public string $foo = 'foo';
+}
+
+class SomeClass4
+{
+	use MyTrait2;
+
+	public int $foo = 1;
+}
+
+trait MyTrait2
+{
+	public function getRandom(): int
+	{
+		$value = random_int(1, 100);
+		if (\is_int($this->foo)) {
+			return $value * $value;
+		}
+
+		return $value;
+	}
+}