Fix phpstan/phpstan#6799: wrongly reported empty array

src/Analyser/ExprHandler/ArrayHandler.php

@@ -12,12 +12,13 @@
 use PHPStan\Analyser\MutatingScope;
 use PHPStan\Analyser\NodeScopeResolver;
 use PHPStan\DependencyInjection\AutowiredService;
+use PHPStan\Node\Expr\IntertwinedVariableByReferenceWithExpr;
 use PHPStan\Node\LiteralArrayItem;
 use PHPStan\Node\LiteralArrayNode;
 use PHPStan\Reflection\InitializerExprTypeResolver;
-use PHPStan\Type\MixedType;
 use PHPStan\Type\Type;
 use function array_merge;
+use function is_string;
 
 /**
  * @implements ExprHandler<Array_>
@@ -76,7 +77,20 @@ public function processExpr(NodeScopeResolver $nodeScopeResolver, Stmt $stmt, Ex
 			}
 
 			$scope = $nodeScopeResolver->lookForUnsetAllowedUndefinedExpressions($scope, $arrayItem->value);
-			$scope = $scope->assignExpression($arrayItem->value, new MixedType(), new MixedType());
+
+			if ($arrayItem->value instanceof Expr\Variable && is_string($arrayItem->value->name)) {
+				$varName = $arrayItem->value->name;
+				$type = $scope->getType($arrayItem->value);
+				$nativeType = $scope->getNativeType($arrayItem->value);
+				// Ensure the variable is defined (PHP creates it if undefined when used by-ref)
+				$scope = $scope->assignExpression($arrayItem->value, $type, $nativeType);
+				// Register intertwined relationship
+				$scope = $scope->assignExpression(
+					new IntertwinedVariableByReferenceWithExpr($varName, $expr, new Expr\Variable($varName)),
+					$type,
+					$nativeType,
+				);
+			}
 		}
 		$nodeScopeResolver->callNodeCallback($nodeCallback, new LiteralArrayNode($expr, $itemNodes), $scope, $storage);
 

src/Analyser/ExprHandler/AssignHandler.php

@@ -179,6 +179,38 @@ static function (MutatingScope $scope) use ($stmt, $expr, $nodeCallback, $contex
 			);
 		}
 
+		if (
+			$expr instanceof Assign
+			&& $expr->var instanceof Variable
+			&& is_string($expr->var->name)
+			&& $expr->expr instanceof Expr\Array_
+		) {
+			$targetVarName = $expr->var->name;
+			foreach ($expr->expr->items as $i => $item) {
+				if (!$item->byRef) {
+					continue;
+				}
+				if (!($item->value instanceof Variable) || !is_string($item->value->name)) {
+					continue;
+				}
+				$refVarName = $item->value->name;
+				$key = $item->key ?? new Node\Scalar\Int_($i);
+				$type = $scope->getType($item->value);
+				$nativeType = $scope->getNativeType($item->value);
+
+				// When $refVarName is assigned, update $targetVar[$key]
+				$scope = $scope->assignExpression(
+					new IntertwinedVariableByReferenceWithExpr(
+						$refVarName,
+						new ArrayDimFetch(new Variable($targetVarName), $key),
+						new Variable($refVarName),
+					),
+					$type,
+					$nativeType,
+				);
+			}
+		}
+
 		$vars = $nodeScopeResolver->getAssignedVariables($expr->var);
 		if (count($vars) > 0) {
 			$varChangedScope = false;

src/Analyser/NodeScopeResolver.php

@@ -3532,6 +3532,30 @@
 						$scope = $scope->invalidateExpression($arg->value, true);
 					}
 				}
+
+				if (
+					!$assignByReference
+					&& $calleeReflection !== null
+					&& !$calleeReflection->hasSideEffects()->no()
+					&& $arg->value instanceof Array_
+				) {
+					foreach ($arg->value->items as $item) {
+						if (!$item->byRef) {
+							continue;
+						}
+						if (!($item->value instanceof Variable) || !is_string($item->value->name)) {
+							continue;
+						}
+						$scope = $this->processVirtualAssign(
+							$scope,
+							$storage,
+							$stmt,
+							$item->value,
+							new TypeExpr(new MixedType()),
+							$nodeCallback,
+						)->getScope();
+					}
+				}
 			}
 		}
 

tests/PHPStan/Analyser/nsrt/bug-6799.php

@@ -51,10 +51,10 @@ function testByRefInArray(): void
 	assertType('array{}', $a);
 
 	$b = [&$a];
-	assertType('mixed', $a); // Could stay array{}
+	assertType('array{}', $a);
 
 	foo($b);
-	assertType('mixed', $a);
+	assertType('array{}', $a);
 }
 
 function testByRefInArrayWithKey(): void
@@ -63,10 +63,10 @@ function testByRefInArrayWithKey(): void
 	assertType("'hello'", $a);
 
 	$b = ['key' => &$a];
-	assertType('mixed', $a); // Could stay 'hello'
+	assertType("'hello'", $a);
 
 	$b['key'] = 42;
-	assertType('mixed', $a); // Could be 42
+	assertType("'hello'", $a);
 }
 
 function testMultipleByRefInArray(): void
@@ -75,13 +75,13 @@ function testMultipleByRefInArray(): void
 	$c = 'test';
 
 	$b = [&$a, 'normal', &$c];
-	assertType('mixed', $a); // Could stay 1
-	assertType('mixed', $c); // Could stay 'test'
+	assertType('1', $a);
+	assertType("'test'", $c);
 
 	$b[0] = 2;
 	$b[1] = 'foo';
 	$b[2] = 'bar';
 
-	assertType('mixed', $a); // Could be 2
-	assertType('mixed', $c); // Could be 'bar'
+	assertType('1', $a);
+	assertType("'test'", $c);
 }