Skip to content

Add toggles for backtick, empty, implicit array creation and short ternary #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 24, 2024
Merged

Add toggles for backtick, empty, implicit array creation and short ternary #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
537b6c7
Add toggles for backtick, empty, implicit array creation and short te…
ruudk Sep 24, 2024
39bc5af
Remove disallowedConstructs
ruudk Sep 24, 2024
a238096
Split strictCalls into strictFunctionCalls, dynamicCallOnStaticMethod…
ruudk Sep 24, 2024
af791e6
Update README.md
ondrejmirtes Sep 24, 2024
2a79937
Update rules.neon
ondrejmirtes Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,16 @@ parameters:
booleansInConditions: false
uselessCast: false
requireParentConstructorCall: false
disallowedConstructs: false
disallowedBacktick: false
disallowedEmpty: false
disallowedImplicitArrayCreation: false
disallowedShortTernary: false
overwriteVariablesWithLoop: false
closureUsesThis: false
matchingInheritedMethodNames: false
numericOperandsInArithmeticOperators: false
strictCalls: false
strictFunctionCalls: false
dynamicCallOnStaticMethod: false
switchConditionsMatchingType: false
noVariableVariables: false
strictArrayFilter: false
Expand Down
30 changes: 19 additions & 11 deletions rules.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,16 @@ parameters:
booleansInConditions: %strictRules.allRules%
uselessCast: %strictRules.allRules%
requireParentConstructorCall: %strictRules.allRules%
disallowedConstructs: %strictRules.allRules%
disallowedBacktick: %strictRules.allRules%
disallowedEmpty: %strictRules.allRules%
disallowedImplicitArrayCreation: %strictRules.allRules%
disallowedShortTernary: %strictRules.allRules%
overwriteVariablesWithLoop: %strictRules.allRules%
closureUsesThis: %strictRules.allRules%
matchingInheritedMethodNames: %strictRules.allRules%
numericOperandsInArithmeticOperators: %strictRules.allRules%
strictCalls: %strictRules.allRules%
strictFunctionCalls: %strictRules.allRules%
dynamicCallOnStaticMethod: %strictRules.allRules%
switchConditionsMatchingType: %strictRules.allRules%
noVariableVariables: %strictRules.allRules%
strictArrayFilter: [%strictRules.allRules%, %featureToggles.bleedingEdge%]
Expand All @@ -38,12 +42,16 @@ parametersSchema:
booleansInConditions: anyOf(bool(), arrayOf(bool()))
uselessCast: anyOf(bool(), arrayOf(bool()))
requireParentConstructorCall: anyOf(bool(), arrayOf(bool()))
disallowedConstructs: anyOf(bool(), arrayOf(bool()))
disallowedBacktick: anyOf(bool(), arrayOf(bool()))
disallowedEmpty: anyOf(bool(), arrayOf(bool()))
disallowedImplicitArrayCreation: anyOf(bool(), arrayOf(bool()))
disallowedShortTernary: anyOf(bool(), arrayOf(bool()))
overwriteVariablesWithLoop: anyOf(bool(), arrayOf(bool()))
closureUsesThis: anyOf(bool(), arrayOf(bool()))
matchingInheritedMethodNames: anyOf(bool(), arrayOf(bool()))
numericOperandsInArithmeticOperators: anyOf(bool(), arrayOf(bool()))
strictCalls: anyOf(bool(), arrayOf(bool()))
strictFunctionCalls: anyOf(bool(), arrayOf(bool()))
dynamicCallOnStaticMethod: anyOf(bool(), arrayOf(bool()))
switchConditionsMatchingType: anyOf(bool(), arrayOf(bool()))
noVariableVariables: anyOf(bool(), arrayOf(bool()))
strictArrayFilter: anyOf(bool(), arrayOf(bool()))
Expand All @@ -69,13 +77,13 @@ conditionalTags:
PHPStan\Rules\Classes\RequireParentConstructCallRule:
phpstan.rules.rule: %strictRules.requireParentConstructorCall%
PHPStan\Rules\DisallowedConstructs\DisallowedBacktickRule:
phpstan.rules.rule: %strictRules.disallowedConstructs%
phpstan.rules.rule: %strictRules.disallowedBacktick%
PHPStan\Rules\DisallowedConstructs\DisallowedEmptyRule:
phpstan.rules.rule: %strictRules.disallowedConstructs%
phpstan.rules.rule: %strictRules.disallowedEmpty%
PHPStan\Rules\DisallowedConstructs\DisallowedImplicitArrayCreationRule:
phpstan.rules.rule: %strictRules.disallowedConstructs%
phpstan.rules.rule: %strictRules.disallowedImplicitArrayCreation%
PHPStan\Rules\DisallowedConstructs\DisallowedShortTernaryRule:
phpstan.rules.rule: %strictRules.disallowedConstructs%
phpstan.rules.rule: %strictRules.disallowedShortTernary%
PHPStan\Rules\ForeachLoop\OverwriteVariablesWithForeachRule:
phpstan.rules.rule: %strictRules.overwriteVariablesWithLoop%
PHPStan\Rules\ForLoop\OverwriteVariablesWithForLoopInitRule:
Expand Down Expand Up @@ -107,11 +115,11 @@ conditionalTags:
PHPStan\Rules\Operators\OperandsInArithmeticSubtractionRule:
phpstan.rules.rule: %strictRules.numericOperandsInArithmeticOperators%
PHPStan\Rules\StrictCalls\DynamicCallOnStaticMethodsRule:
phpstan.rules.rule: %strictRules.strictCalls%
phpstan.rules.rule: %strictRules.dynamicCallOnStaticMethod%
PHPStan\Rules\StrictCalls\DynamicCallOnStaticMethodsCallableRule:
phpstan.rules.rule: %strictRules.strictCalls%
phpstan.rules.rule: %strictRules.dynamicCallOnStaticMethod%
PHPStan\Rules\StrictCalls\StrictFunctionCallsRule:
phpstan.rules.rule: %strictRules.strictCalls%
phpstan.rules.rule: %strictRules.strictFunctionCalls%
PHPStan\Rules\SwitchConditions\MatchingTypeInSwitchCaseConditionRule:
phpstan.rules.rule: %strictRules.switchConditionsMatchingType%
PHPStan\Rules\VariableVariables\VariableMethodCallRule:
Expand Down