Skip to content

UselessCastRule: do cheaper check first #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2025
Merged

UselessCastRule: do cheaper check first #274

merged 1 commit into from
Jul 17, 2025

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Jun 8, 2025

just switching the order of early return conditions, so that simple bool comparisons are done first

@ondrejmirtes ondrejmirtes merged commit 1f1358d into phpstan:2.0.x Jul 17, 2025
31 checks passed
@ondrejmirtes
Copy link
Member

Thank you.

@staabm staabm deleted the cheap branch July 17, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@staabm @ondrejmirtes