Fix issue with TwigEnvironment loader's not used when provided#1
Open
MacFJA wants to merge 1 commit intophptransformers:masterfrom
Open
Fix issue with TwigEnvironment loader's not used when provided#1MacFJA wants to merge 1 commit intophptransformers:masterfrom
MacFJA wants to merge 1 commit intophptransformers:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an issue when TwigEnvironment is passed to the TwigTransformer. The loader initialized with the TwigEnvironment is not used.
This PR fix it by storing in the class the fact that the transformer was created with an already created TwigEnvironment and use this information to directly use TwigEnvironment loader instead of creating a new one.
(Original PR: phptransformers/phptransformer#29)