Skip to content

fix(API): pass translation_key_ids when removing keys from job #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theSoenke merged 2 commits into from
Jan 29, 2025
Merged

fix(API): pass translation_key_ids when removing keys from job #771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bc2f9e
fix(CLI): pass translation_key_ids when removing keys from job
theSoenke Jan 29, 2025
1031d82
Set translation_key_ids as required
theSoenke Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 32 additions & 25 deletions doc/compiled.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11288,29 +11288,6 @@
},
{
"$ref": "#/components/parameters/id"
},
{
"description": "specify the branch to use",
"example": "my-feature-branch",
"name": "branch",
"in": "query",
"schema": {
"type": "string"
}
},
{
"description": "ids of keys that should be removed from the job",
"example": [
"abcd1234cdef1234abcd1234cdef1234"
],
"name": "translation_key_ids",
"in": "query",
"schema": {
"type": "array",
"items": {
"type": "string"
}
}
}
],
"responses": {
Expand All @@ -11334,10 +11311,40 @@
},
{
"lang": "CLI v2",
"source": "phrase jobs keys_delete \\\n--project_id <project_id> \\\n--id <id> \\\n--branch my-feature-branch \\\n--translation_key_ids \"abcd1234cdef1234abcd1234cdef1234\" \\\n--access_token <token>"
"source": "phrase jobs keys_delete \\\n--project_id <project_id> \\\n--id <id> \\\n--branch my-feature-branch \\\n--data '{\"branch\": \"my-feature-branch\", \"translation_key_ids\": [\"abcd1234cdef1234abcd1234cdef1234\"]}' \\\n--access_token <token>"
}
],
"x-cli-version": "2.5"
"requestBody": {
"required": true,
"content": {
"application/json": {
"schema": {
"type": "object",
"title": "job/keys/delete/parameters",
"required": [
"translation_key_ids"
],
"properties": {
"branch": {
"description": "specify the branch to use",
"type": "string",
"example": "my-feature-branch"
},
"translation_key_ids": {
"description": "ids of keys that should be deleted from the job",
"type": "array",
"items": {
"type": "string"
},
"example": [
"abcd1234cdef1234abcd1234cdef1234"
]
}
}
}
}
}
}
}
},
"/projects/{project_id}/job_templates": {
Expand Down
39 changes: 22 additions & 17 deletions paths/jobs/remove_keys.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,21 +8,6 @@ parameters:
- "$ref": "../../parameters.yaml#/X-PhraseApp-OTP"
- "$ref": "../../parameters.yaml#/project_id"
- "$ref": "../../parameters.yaml#/id"
- description: specify the branch to use
example: my-feature-branch
name: branch
in: query
schema:
type: string
- description: ids of keys that should be removed from the job
example:
- abcd1234cdef1234abcd1234cdef1234
name: translation_key_ids
in: query
schema:
type: array
items:
type: string
responses:
'204':
"$ref": "../../responses.yaml#/204"
Expand All @@ -46,6 +31,26 @@ x-code-samples:
--project_id <project_id> \
--id <id> \
--branch my-feature-branch \
--translation_key_ids "abcd1234cdef1234abcd1234cdef1234" \
--data '{"branch": "my-feature-branch", "translation_key_ids": ["abcd1234cdef1234abcd1234cdef1234"]}' \
--access_token <token>
x-cli-version: '2.5'
requestBody:
required: true
content:
application/json:
schema:
type: object
title: job/keys/delete/parameters
required:
- translation_key_ids
properties:
branch:
description: specify the branch to use
type: string
example: my-feature-branch
translation_key_ids:
description: ids of keys that should be deleted from the job
type: array
items:
type: string
example:
- abcd1234cdef1234abcd1234cdef1234
Loading