Skip to content

⚡ Bolt: Optimize IsTheSame to be allocation-free (O(N)) #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
google-labs-jules wants to merge 1 commit into
base: v4
Choose a base branch
from
Open

⚡ Bolt: Optimize IsTheSame to be allocation-free (O(N)) #155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 31 additions & 6 deletions v4/DynamicsCrm.DevKit.Shared/Helper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,14 +72,39 @@ public static string DecryptString(string cipherText)
catch { return cipherText; }
}

/// <summary>
/// Optimized comparison that ignores whitespace (Space, Tab, CR, LF) and performs a case-insensitive check.
/// This implementation is allocation-free (O(N)) compared to the previous Replace-based approach.
Copy link

Copilot AI Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment states "allocation-free (O(N))" but O(N) refers to time complexity, not memory allocation. Consider revising to something like: "This implementation avoids string allocations and runs in O(N) time" or "This allocation-free implementation has O(N) time complexity" to clearly separate the two concepts.

Suggested change
/// This implementation is allocation-free (O(N)) compared to the previous Replace-based approach.
/// This allocation-free implementation has O(N) time complexity compared to the previous Replace-based approach.

Copilot uses AI. Check for mistakes.
/// </summary>
public static bool IsTheSame(string value1, string value2)
{
if (value1 == null && value2 == null) return true;
if (value1 != null && value2 == null) return false;
if (value1 == null && value2 != null) return false;
value1 = value1.Replace("\r\n", string.Empty).Replace("\r", string.Empty).Replace("\t", string.Empty).Replace(" ", string.Empty).Trim();
value2 = value2.Replace("\r\n", string.Empty).Replace("\r", string.Empty).Replace("\t", string.Empty).Replace(" ", string.Empty).Trim();
return string.Equals(value1, value2, StringComparison.OrdinalIgnoreCase);
if (ReferenceEquals(value1, value2)) return true;
if (value1 == null || value2 == null) return false;

var len1 = value1.Length;
var len2 = value2.Length;
var i1 = 0;
var i2 = 0;

while (i1 < len1 || i2 < len2)
{
while (i1 < len1 && IsIgnoredChar(value1[i1])) i1++;
while (i2 < len2 && IsIgnoredChar(value2[i2])) i2++;

if (i1 == len1 && i2 == len2) return true;
if (i1 == len1 || i2 == len2) return false;

if (char.ToUpperInvariant(value1[i1]) != char.ToUpperInvariant(value2[i2])) return false;

i1++;
i2++;
}
return true;
}

private static bool IsIgnoredChar(char c)
{
return c == '\r' || c == '\n' || c == '\t' || c == ' ';
}

public static async Task<string> ReadEmbeddedResourceAsync(string path)
Expand Down
Loading