β‘ Bolt: Optimized string operations in Helper.cs #158
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π‘ What:
Replacechain inIsTheSamewith an allocation-free loop that skips whitespace and performs case-insensitive comparison.GetIdentifierwithStringBuilder.π― Why:
IsTheSame: The original implementation created 4+ intermediate string allocations per call (usingReplace). Since this method is used for comparing generated code (potentially large strings), this created significant memory pressure. The new implementation is allocation-free (O(1) memory) and likely much faster (O(N) time).GetIdentifier: String concatenation in a loop is O(NΒ²). UsingStringBuildermakes it O(N).π Impact:
\rand\n).π¬ Measurement:
ReferenceEqualscheck for instant return on identical objects.GetIdentifier.PR created automatically by Jules for task 8070584608386072024 started by @phuocle