⚡ Bolt: Optimize IsTheSame to avoid string allocations #159
Conversation
💡 What: Replaced the chained `Replace` and `Trim` calls in `Helper.IsTheSame` with a zero-allocation character iterator loop. 🎯 Why: The original implementation created up to 10 intermediate string objects for every comparison, causing significant GC pressure during bulk operations like code generation. 📊 Impact: Eliminates string allocations for this method completely (O(1) memory vs O(N) allocations previously). 🔬 Measurement: Verified logic equivalence through manual trace and code review. Code handles nulls, whitespace trimming, and ignores CR/LF/Tab/Space identically to the original intent.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR optimizes the
Helper.IsTheSamemethod in the Shared project.Previously, the method normalized strings by creating multiple intermediate copies to remove whitespace and line endings before comparison. This was inefficient for high-frequency usage (e.g. checking if generated files have changed).
The new implementation iterates through the strings in-place, skipping ignored characters and whitespace, without allocating any new string objects. It preserves the original case-insensitive comparison logic and adds robust null handling.
Key changes:
IsIgnoredCharhelper.IsTheSameto use pointer-like index manipulation instead of string mutation.PR created automatically by Jules for task 7720632062224996036 started by @phuocle