Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/bolt.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2024-05-22 - [Optimizing String Manipulations in Code Generation]
**Learning:** The codebase relies heavily on string manipulations for code generation (e.g., `SafeIdentifier`). I observed a pattern of chained `string.Replace()` calls which creates unnecessary intermediate allocations.
**Action:** Future optimizations should focus on replacing chained `Replace` calls with single-pass `StringBuilder` filtering or `regex` replacements where appropriate, similar to the `GetIdentifier` optimization.
8 changes: 5 additions & 3 deletions v4/DynamicsCrm.DevKit.Shared/Helper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -104,13 +104,15 @@ public static string GetSchemaNameFromFile(string file, string endsWith)

private static string GetIdentifier(string name)
{
var value = string.Empty;
if (string.IsNullOrEmpty(name)) return string.Empty;
// Optimization: Use StringBuilder to avoid intermediate string allocations in loop
var sb = new StringBuilder(name.Length);
for (int i = 0; i < name.Length; ++i)
{
if (char.IsLetterOrDigit(name[i]) || name[i] == ' ' || name[i] == '-' || name[i] == '_')
value += name[i];
sb.Append(name[i]);
}
return value;
return sb.ToString();
}

public static string SafeIdentifier(string name)
Expand Down