Skip to content

Conversation

@sbaldu
Copy link
Collaborator

@sbaldu sbaldu commented Feb 6, 2025

Deifne a new AdjacencyMatrix class that implements a sparse matrix in CSR format (issue #254).

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cppcheck (reported by Codacy) found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@codecov
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 99.29825% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.36%. Comparing base (1363a88) to head (12f0076).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/dsm/sources/AdjacencyMatrix.cpp 96.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #257      +/-   ##
==========================================
+ Coverage   89.80%   90.36%   +0.56%     
==========================================
  Files          34       37       +3     
  Lines        4531     4816     +285     
  Branches      447      455       +8     
==========================================
+ Hits         4069     4352     +283     
- Misses        462      464       +2     
Flag Coverage Δ
unittests 90.36% <99.29%> (+0.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Grufoony Grufoony merged commit de6fd63 into main Feb 6, 2025
28 checks passed
@Grufoony Grufoony deleted the rework-sparse-matrix branch February 6, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants