Skip to content

Conversation

@Grufoony
Copy link
Collaborator

No description provided.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cppcheck (reported by Codacy) found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@codecov
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 84.52381% with 26 lines in your changes missing coverage. Please review.

Project coverage is 90.63%. Comparing base (1848e83) to head (e218f6a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/dsm/sources/Graph.cpp 69.23% 24 Missing ⚠️
src/dsm/sources/Road.cpp 50.00% 1 Missing ⚠️
src/dsm/sources/Street.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #269      +/-   ##
==========================================
- Coverage   90.90%   90.63%   -0.27%     
==========================================
  Files          35       35              
  Lines        5011     5082      +71     
  Branches      462      462              
==========================================
+ Hits         4555     4606      +51     
- Misses        456      476      +20     
Flag Coverage Δ
unittests 90.63% <84.52%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Grufoony Grufoony changed the title Add file exports for nodes and edges Add exportNodes and exportEdges functions in Graph class. Handle geometry attribute in Edge class. Feb 18, 2025
@Grufoony Grufoony merged commit 855ee0e into main Feb 18, 2025
26 of 28 checks passed
@Grufoony Grufoony deleted the edgeGeometry branch February 18, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants