Skip to content

Conversation

@Grufoony
Copy link
Collaborator

No description provided.

@Grufoony Grufoony requested a review from sbaldu February 18, 2025 14:18
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cppcheck (reported by Codacy) found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@codecov
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 90.79755% with 30 lines in your changes missing coverage. Please review.

Project coverage is 90.77%. Comparing base (855ee0e) to head (4369f17).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/dsm/sources/RoadNetwork.cpp 81.42% 13 Missing ⚠️
src/dsm/headers/Dynamics.hpp 75.00% 6 Missing ⚠️
src/dsm/headers/Network.hpp 92.30% 4 Missing ⚠️
src/dsm/headers/Node.hpp 0.00% 2 Missing ⚠️
src/dsm/headers/RoadDynamics.hpp 94.28% 2 Missing ⚠️
src/dsm/sources/FirstOrderDynamics.cpp 75.00% 2 Missing ⚠️
src/dsm/sources/Street.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #270      +/-   ##
==========================================
+ Coverage   90.63%   90.77%   +0.13%     
==========================================
  Files          35       36       +1     
  Lines        5082     5083       +1     
  Branches      462      463       +1     
==========================================
+ Hits         4606     4614       +8     
+ Misses        476      469       -7     
Flag Coverage Δ
unittests 90.77% <90.79%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Grufoony Grufoony merged commit a9f5d94 into main Feb 18, 2025
28 checks passed
@Grufoony Grufoony deleted the generalNetwork branch February 18, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants