Skip to content

Conversation

@Grufoony
Copy link
Collaborator

@Grufoony Grufoony requested a review from sbaldu February 22, 2025 10:54
@codecov
Copy link

codecov bot commented Feb 22, 2025

Codecov Report

Attention: Patch coverage is 95.18072% with 8 lines in your changes missing coverage. Please review.

Project coverage is 90.66%. Comparing base (25c7688) to head (feb8842).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/dsm/sources/Agent.cpp 91.04% 6 Missing ⚠️
src/dsm/headers/RoadDynamics.hpp 96.49% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #277      +/-   ##
==========================================
+ Coverage   90.63%   90.66%   +0.02%     
==========================================
  Files          36       36              
  Lines        5113     5086      -27     
  Branches      465      460       -5     
==========================================
- Hits         4634     4611      -23     
+ Misses        479      475       -4     
Flag Coverage Δ
unittests 90.66% <95.18%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cppcheck (reported by Codacy) found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@Grufoony Grufoony marked this pull request as ready for review February 24, 2025 08:20
@Grufoony Grufoony merged commit 017586d into main Feb 24, 2025
31 checks passed
@Grufoony Grufoony deleted the reworkAgentLogic branch February 24, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor Agent class

2 participants