Skip to content

Conversation

@Grufoony
Copy link
Collaborator

@Grufoony Grufoony commented Dec 4, 2025

No description provided.

@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 93.93939% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.41%. Comparing base (a102090) to head (5bf795b).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/dsf/mobility/Agent.hpp 90.47% 2 Missing ⚠️
test/mobility/Test_dynamics.cpp 90.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #377      +/-   ##
==========================================
+ Coverage   83.24%   83.41%   +0.17%     
==========================================
  Files          53       53              
  Lines        5330     5392      +62     
  Branches      608      614       +6     
==========================================
+ Hits         4437     4498      +61     
- Misses        882      883       +1     
  Partials       11       11              
Flag Coverage Δ
unittests 83.41% <93.93%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

/// @details If possible, the agent's itinerary is updated by removing the first element
/// from the itinerary's vector.
inline void setMaxDistance(double const maxDistance) {
maxDistance > 0. ? m_maxDistance = maxDistance

Check warning

Code scanning / Cppcheck (reported by Codacy)

AST broken, ternary operator missing operand(s) Warning

AST broken, ternary operator missing operand(s)

This comment was marked as outdated.

dynamics.setMeanTravelDistance(1000.0);

// Set origin nodes
std::unordered_map<Id, double> origins;

Check notice

Code scanning / Cppcheck (reported by Codacy)

MISRA 12.3 rule Note test

MISRA 12.3 rule

// Set origin nodes
std::unordered_map<Id, double> origins;
for (const auto& [id, node] : defaultNetwork.nodes()) {

Check notice

Code scanning / Cppcheck (reported by Codacy)

MISRA 12.3 rule Note test

MISRA 12.3 rule
SUBCASE("setMeanTravelTime") {
dynamics.setMeanTravelTime(3600);

std::unordered_map<Id, double> origins;

Check notice

Code scanning / Cppcheck (reported by Codacy)

MISRA 12.3 rule Note test

MISRA 12.3 rule
dynamics.setMeanTravelTime(3600);

std::unordered_map<Id, double> origins;
for (const auto& [id, node] : defaultNetwork.nodes()) {

Check notice

Code scanning / Cppcheck (reported by Codacy)

MISRA 12.3 rule Note test

MISRA 12.3 rule
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Grufoony Grufoony merged commit e46ba54 into main Dec 5, 2025
42 checks passed
@Grufoony Grufoony deleted the expDist branch December 5, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants