-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update README.md #1848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Update README.md #1848
Conversation
added a docker compose option when upgrading. Signed-off-by: jcstang <[email protected]>
@@ -243,7 +243,7 @@ The standard Pi-hole customization abilities apply to this docker, but with dock | |||
|
|||
Do not attempt to upgrade (`pihole -up`) or reconfigure (`pihole -r`). | |||
|
|||
New images will be released for upgrades, upgrading by replacing your old container with a fresh upgraded image is the 'docker way'. Long-living docker containers are not the docker way since they aim to be portable and reproducible, why not re-create them often! Just to prove you can. | |||
New images will be released for upgrades, upgrading by replacing your old container with a fresh upgraded image is the 'docker way'. Long-living docker containers are not the docker way since they aim to be portable and reproducible, why not re-create them often! **Just to prove you can.** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you change the styling here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just meant to change the styling for "Just to prove you can.". Thought an emphasis on this phrase would be impactful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New images will be released for upgrades, upgrading by replacing your old container with a fresh upgraded image is the 'docker way'. Long-living docker containers are not the docker way since they aim to be portable and reproducible, why not re-create them often! **Just to prove you can.** | |
New images will be released for upgrades, upgrading by replacing your old container with a fresh upgraded image is the 'docker way'. Long-living docker containers are not the docker way since they aim to be portable and reproducible, why not re-create them often! |
I think this could even be removed.
Co-authored-by: yubiuser <[email protected]> Signed-off-by: jcstang <[email protected]>
@@ -252,7 +252,7 @@ New images will be released for upgrades, upgrading by replacing your old contai | |||
2. Throw away your container: `docker rm -f pihole` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2. Throw away your container: `docker rm -f pihole` | |
2. Throw away your container: `docker compose down` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably switch this up for a compose
command, too. Otherwise it doesn't make a lot of sense in the grand scheme of things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm undecided here... We have a few places suggesting docker run
commands and arguments in the Docs and in the README:
- Docs page shows both commands: https://docs.pi-hole.net/docker/
- This table uses
docker run
format for all arguments; - this line shows a
docker run
argument; - this line uses both (
docker run
anddocker compose
).
Maybe we could suggest both commands:
2. Throw away your container: `docker rm -f pihole` | |
2. Throw away your container: `docker rm -f pihole` or `docker compose down`, depending on how you started your container. |
And also change the step 3.
, adding:
-3. Start your container with the newer base image: `docker compose up -d`
+3. Start your container with the newer base image: `docker compose up -d` or `docker run <args>`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would switch everything to compose syntax. Are users really running docker run
by hand with all the necessary options/flags?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are users really running docker run
The trick is never to be surprised, and then they cannot surprise you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can avoid the docker compose down
step by using: docker compose pull && docker compose up --force-create
added a docker compose option when upgrading.
Description
Added a line that talked about docker compose.
Motivation and Context
Clarify for users like me who use docker compose vs docker run.
How Has This Been Tested?
n/a
Types of changes
Checklist: