-
-
Notifications
You must be signed in to change notification settings - Fork 226
Alpine ssl #1256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Alpine ssl #1256
Conversation
Signed-off-by: David Tanner <[email protected]>
✅ Deploy Preview for pihole-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
I have no special insight on when reviews happen, I'm just another contributor. But I'm happy to give my input here. My concern would be that although dehydrated is listed on the Let's encrypt ACME Client Implementations page, cfhookbash is not. cfhokbash seems to be quite a small project and also has not updated for some time (last code change was 18 months ago, last issue was raised in 2021). If users run into problems with it are they going to be able to get assistance? |
As for the hook being small, it really is small. For support I'm not really sure. This is how I got things set up, and it has been working. Version 4.9.0 was a PR that was merged last year. It doesn't feel right to me to say that because a project hasn't had issues means it isn't supported or can't be fixed. What would be your recommendation? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how to judge this PR best. I'm not using Pi-hole on Alpine and any of these tools to setup SSL encryption.
The other thing is: this is a highly specific topic which (wild guess!) is only interesting to a handful of users out there. Should we really include and maintain such a guide?
It's a good point. We used to have some guides for alternative webservers - which I guess kinda sorta loosely falls under the same category. IIRC those guides were removed when we transitioned from v5->v6 because they were outdated and we haven't rewritten them. Personally I think I would prefer a much more generic guide on how to auto generate SSL certs on multiple distros (and even how to just stick it behind a reverse proxy with SSL generation built into it) |
I agree. Currently no member of the development team uses Alpine Linux (which is probably why it took us so long to review this PR). If an Alpine update changes something that breaks Pi-hole, we won't know right away and probably won't be able to fix/maintain the guide. |
Thank you for your contribution to the Pi-hole Community!
Please read the comments below to help us consider your Pull Request.
We are all volunteers and completing the process outlined will help us review your commits quicker.
Please make sure you
What does this PR aim to accomplish?:
I recently set up pihole on Alpine linux bare metal with an SSL certificate signed by LetsEncrypt. The process took a bit of effort to put everything together, and I want to share what I learned with others.
How does this PR accomplish the above?:
Using the instructions here, users should be able to set up Dehydrated for Alpine, and CloudFlare for DNS, to get SSL certificates for their PiHole running on Alpine baremetal
Link documentation PRs if any are needed to support this PR:
N/A
By submitting this pull request, I confirm the following:
git rebase
)