Conversation
klemens-st
reviewed
Feb 15, 2026
Collaborator
klemens-st
left a comment
There was a problem hiding this comment.
Hi, I left some comments which make the implementation more consistent with what's already elsewhere in the code. Otherwise, if the reported vulnerability is about the script tag only, it should be good.
Owner
Author
|
Thanks @klemens-st!!!! Thanks for reminding me about that util function and how the other thing had been solved previously. I need to review the entire codebase again soon to remember what's there 😅 The main thing is the |
c43ab7a to
49b7abc
Compare
49b7abc to
dad9438
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A quick update with a couple of small things to avoid security scares, and potentially a fix for something reported on the forum (I couldn't reproduce the issue). @klemens-st let me know what you think, but no pressure.