Skip to content

Conversation

@Skelmis
Copy link
Contributor

@Skelmis Skelmis commented Jan 16, 2025

The backend requires the project to be built for dist files to be in place. This PR just makes that a touch clearer

@dantownsend
Copy link
Member

Thanks for this. The PR is failing due to some unrelated problems with the CI. I'll fix it, then merge in this branch.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.02%. Comparing base (1157c12) to head (ed010e4).
Report is 31 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #433      +/-   ##
==========================================
+ Coverage   93.42%   94.02%   +0.60%     
==========================================
  Files           5        5              
  Lines         365      402      +37     
==========================================
+ Hits          341      378      +37     
  Misses         24       24              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dantownsend dantownsend merged commit 0a36afc into piccolo-orm:master Jan 16, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants