add enum support to custom forms

admin_ui/src/components/NewForm.vue

@@ -12,6 +12,7 @@
                 v-bind:type="getType(property)"
                 v-bind:value="property.default"
                 v-bind:isNullable="isNullable(property)"
+                v-bind:choices="property.extra?.choices"
                 v-bind:timeResolution="
                     schema?.extra?.time_resolution[columnName]
                 "

e2e/test_forms.py

@@ -1,6 +1,7 @@
 from playwright.sync_api import Page
 
 from piccolo_admin.example.forms.csv import FORM as CSV_FORM
+from piccolo_admin.example.forms.enum import FORM as ENUM_FORM
 from piccolo_admin.example.forms.image import FORM as IMAGE_FORM
 from piccolo_admin.example.forms.nullable import FORM as NULLABLE_FORM
 
@@ -79,3 +80,28 @@ def test_nullable_form(page: Page, dev_server):
         and response.status == 200
     ):
         form_page.submit_form()
+
+
+def test_form_enum(page: Page, dev_server):
+    """
+    Make sure custom forms support the usage of Enum's.
+    """
+    login_page = LoginPage(page=page)
+    login_page.reset()
+    login_page.login()
+
+    form_page = FormPage(
+        page=page,
+        form_slug=ENUM_FORM.slug,
+    )
+    form_page.reset()
+    page.locator('input[name="username"]').fill("piccolo")
+    page.locator('input[name="email"]').fill("piccolo@example.com")
+    page.locator('select[name="permissions"]').select_option("admissions")
+
+    with page.expect_response(
+        lambda response: response.url == f"{BASE_URL}/api/forms/enum-form/"
+        and response.request.method == "POST"
+        and response.status == 200
+    ):
+        form_page.submit_form()

piccolo_admin/endpoints.py

@@ -62,6 +62,7 @@
     TranslationListItem,
     TranslationListResponse,
 )
+from .utils import convert_enum_to_choices
 from .version import __VERSION__ as PICCOLO_ADMIN_VERSION
 
 logger = logging.getLogger(__name__)
@@ -395,6 +396,7 @@ def __init__(
             t.Union[FormResponse, t.Coroutine[None, None, FormResponse]],
         ],
         description: t.Optional[str] = None,
+        choices: t.Optional[t.Dict[str, t.Any]] = None,
         form_group: t.Optional[str] = None,
     ):
         self.name = name
@@ -403,6 +405,19 @@ def __init__(
         self.description = description
         self.form_group = form_group
         self.slug = self.name.replace(" ", "-").lower()
+        if choices is not None:
+            for field_name, field_value in choices.items():
+                # update model_fields, field annotation and
+                # rebuild the model for the changes to take effect
+                pydantic_model.model_fields[field_name] = Field(
+                    json_schema_extra={
+                        "extra": {
+                            "choices": convert_enum_to_choices(field_value)
+                        }
+                    },
+                )
+                pydantic_model.model_fields[field_name].annotation = str
+                pydantic_model.model_rebuild(force=True)
 
 
 class FormConfigResponseModel(BaseModel):

piccolo_admin/example/forms/__init__.py

@@ -1,6 +1,7 @@
 from .calculator import FORM as CALCULATOR_FORM
 from .csv import FORM as CSV_FORM
 from .email import FORM as EMAIL_FORM
+from .enum import FORM as ENUM_FORM
 from .image import FORM as IMAGE_FORM
 from .nullable import FORM as MEGA_FORM
 
@@ -10,4 +11,5 @@
     EMAIL_FORM,
     IMAGE_FORM,
     MEGA_FORM,
+    ENUM_FORM,
 ]

piccolo_admin/example/forms/enum.py

@@ -0,0 +1,35 @@
+import enum
+
+from pydantic import BaseModel, EmailStr
+from starlette.requests import Request
+
+from piccolo_admin.endpoints import FormConfig
+
+
+# An example of using Python enum in custom forms
+class Permission(str, enum.Enum):
+    admissions = "admissions"
+    gallery = "gallery"
+    notices = "notices"
+    uploads = "uploads"
+
+
+class NewStaffModel(BaseModel):
+    username: str
+    email: EmailStr
+    superuser: bool
+
+
+def new_staff_endpoint(request: Request, data: NewStaffModel) -> str:
+    print(data)
+    return "A new staff member has been successfully created."
+
+
+FORM = FormConfig(
+    name="Enum form",
+    pydantic_model=NewStaffModel,
+    endpoint=new_staff_endpoint,
+    description="Make a enum form.",
+    choices={"permissions": Permission},
+    form_group="Text forms",
+)

piccolo_admin/utils.py

@@ -0,0 +1,13 @@
+from __future__ import annotations
+
+import typing as t
+
+
+def convert_enum_to_choices(enum_data: t.Any) -> t.Dict[str, t.Any]:
+    choices = {}
+    for item in enum_data:
+        choices[item.name] = {
+            "display_name": item.name,
+            "value": item.value,
+        }
+    return choices

tests/test_endpoints.py

@@ -311,6 +311,11 @@ def test_forms(self):
                     "name": "Nullable fields",
                     "slug": "nullable-fields",
                 },
+                {
+                    "name": "Enum form",
+                    "slug": "enum-form",
+                    "description": "Make a enum form.",
+                },
             ],
         )
 
@@ -526,7 +531,12 @@ def test_forms_grouped(self):
                             "description": "Make a booking for a customer.",
                             "name": "Booking form",
                             "slug": "booking-form",
-                        }
+                        },
+                        {
+                            "name": "Enum form",
+                            "slug": "enum-form",
+                            "description": "Make a enum form.",
+                        },
                     ],
                     "Test forms": [
                         {