Conversation
|
@dantownsend I haven't seen that before, but Piccolo API still supports Python |
|
@sinisaos Yes, we should drop Python 3.8. Can you possibly split this into multiple PRs - the changes to |
|
@dantownsend I reverted the dependency changes. I only need to change one type annotation in |
requirements/doc-requirements.txt
Outdated
| Sphinx==7.2.6 | ||
| piccolo-theme==0.21.0 | ||
| sphinx-autobuild==2024.2.4 | ||
| sphinx-autobuild==2024.2.4 No newline at end of file |
There was a problem hiding this comment.
What changed here? Just whitespace?
|
|
||
| @classmethod | ||
| async def authenticate_sync(cls, token: str) -> t.Optional[int]: | ||
| async def authenticate_sync(cls, token: str) -> First: |
There was a problem hiding this comment.
I think this is wrong - authenticate_sync shouldn't be async.
Lets pull this out into a separate PR - it needs properly refactoring.
|
@sinisaos I've merged in the setup.py and GitHub actions changes. In this PR, would you be able to add back the changes to requirements.txt etc? |
|
@dantownsend I reverted the changes. I hope that's okay. |
|
|
||
| self.alias = f"{piccolo_crud.table._meta.tablename}__{id(self)}" | ||
|
|
||
| global ANNOTATIONS |
There was a problem hiding this comment.
We need to keep this - we need to make sure the global ANNOTATIONS are updated. Is it causing mypy errors? If so, lets ignore the error.
There was a problem hiding this comment.
I put a noqa comment next to it.
|
@sinisaos Thanks! |
2 participants
Update dependecies and fix a few mypy errors.