Skip to content

Fixes CVE-2020-6563 #2243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fixes CVE-2020-6563 #2243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions ...lorenzo/flutter_inappwebview_android/webview/in_app_webview/InAppWebViewChromeClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,6 +848,22 @@ public boolean onActivityResult(int requestCode, int resultCode, Intent data) {
return true;
}

// Excludes intents who want to obtain sandbox files.
// Fixes CVE-2020-6563.
if (data != null && data.getData().getPath() != null) {
final String path = data.getData().getPath();
final File file = new File(path);
String normalized;
try {
normalized = file.getCanonicalPath();
} catch (IOException e) {
normalized = path;
}
if (normalized.startsWith("/data")) {
data.setData(Uri.EMPTY);
}
}

// based off of which button was pressed, we get an activity result and a file
// the camera activity doesn't properly return the filename* (I think?) so we use
// this filename instead
Expand Down