bug-fix: update evaluateJavaScript method signature to use @MainActor… #2574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for completionHandler in iOS and macOS InAppWebView classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Fix evaluateJavaScript override error for Xcode 16
Description
This PR fixes the override issue for evaluateJavaScript in iOS and macOS InAppWebView classes when building with Xcode 16. The change updates the function signature to align with the latest Swift updates.
Testing and Review Notes
To test this fix:
Build a Flutter project using flutter_inappwebview with Xcode 16.
Ensure that no override error appears for evaluateJavaScript.
Verify that JavaScript execution still functions correctly in InAppWebView.
To Do
Verify that the issue is resolved with this change
Ensure compatibility with previous Xcode versions
Add testing notes in PR description
Request review from maintainers