Fix: keepAlive not working when URL changed #2614
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When using
InAppWebViewKeepAlive
, if the URL is changed from the initial URL and the WebView is removed and re-added to the widget tree, it loads the initial URL instead of the last URL that was navigated to.Steps to reproduce:
https://jumble.social/
and setkeepAlive = InAppWebViewKeepAlive()
https://jumble.social/notes/bbb
InAppWebViewKeepAlive
objecthttps://jumble.social/
instead ofhttps://jumble.social/notes/bbb
Fix
This PR adds URL tracking to the keepAlive functionality:
currentUrl
property to theInAppWebViewControllerKeepAliveProps
classonLoadStop
event handlers in Android and iOS implementations to save the current URL to the keepAlive propertiesFixes #2613