basic fillp(), support for tabled palettes in pal(), support for custom menuitem()#10
Open
TheRoboZ wants to merge 3 commits intopico-8:masterfrom
Open
basic fillp(), support for tabled palettes in pal(), support for custom menuitem()#10TheRoboZ wants to merge 3 commits intopico-8:masterfrom
TheRoboZ wants to merge 3 commits intopico-8:masterfrom
Conversation
TheRoboZ
changed the title
Collaborator
|
Can you provide some test ROMs for these changes? It's admittedly been a while since I last actively made PICO-8 games. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I implemented a basic fillp that for now supports patterns in color+black or color+transparent, for now it's only applied to draw_shader, none of the new sprite patterns etc.. Also it doesn't set anything in the draw state since it's not implemented.
In addition I added support for palette in tables passed to pal() such as pal({1,2,3,4,5,6,7,8,9,10,...}) to remap multiple colors at once as I used it a lot in my games, and cleaned up a bit all shaders settings in pal()
I have a couple "in progress" things left to add, then I'll take a break to work on my next game and after that continue this so it supports at least my other games