Add test documenting variable binding persistence in failed patterns#4
Draft
Copilot wants to merge 6 commits intopattern_matchingfrom
Draft
Add test documenting variable binding persistence in failed patterns#4Copilot wants to merge 6 commits intopattern_matchingfrom
Copilot wants to merge 6 commits intopattern_matchingfrom
Conversation
Co-authored-by: hasumikin <8454208+hasumikin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update implementation for pattern matching support
Add test documenting variable binding persistence in failed patterns
Feb 10, 2026
bfa030a to
2f873a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses clarification from @hasumikin that variables bound during pattern matching persist even when the pattern fails to match completely, matching CRuby semantics.
Changes
Example
This confirms the current implementation in
PM_LOCAL_VARIABLE_TARGET_NODE(lines 687-696 ofsrc/codegen_prism.inc) is correct and matches CRuby behavior.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.