Implemented annotations for each entity#315
Open
tychokamphuis-aqqo wants to merge 1 commit intopicqer:mainfrom
Open
Implemented annotations for each entity#315tychokamphuis-aqqo wants to merge 1 commit intopicqer:mainfrom
tychokamphuis-aqqo wants to merge 1 commit intopicqer:mainfrom
Conversation
stephangroen
reviewed
Feb 8, 2026
Member
There was a problem hiding this comment.
Thanks for the PR! I do want to flag some breaking changes introduced by the $fillable modifications:
Breaking changes
Fields removed from $fillable
| Entity | Removed field | Impact |
|---|---|---|
Subscription |
amount |
Setting amount on a Subscription will be silently ignored |
Subscription |
discount |
Setting discount on a Subscription will be silently ignored |
Subscription |
mergeable |
Setting mergeable on a Subscription will be silently ignored |
Subscription |
prices_are_incl_tax |
Setting prices_are_incl_tax on a Subscription will be silently ignored |
Subscription |
subscription_prices_are_incl_tax |
Setting subscription_prices_are_incl_tax on a Subscription will be silently ignored |
Product |
product_type |
Setting product_type on a Product will be silently ignored |
FinancialStatement |
update_journal_entries |
Setting update_journal_entries on a FinancialStatement will be silently ignored |
Fields renamed in $fillable
| Entity | Old field | New field | Impact |
|---|---|---|---|
DocumentStyle |
print_on_stationary |
print_on_stationery |
Code referencing print_on_stationary will silently stop working |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces explicit property definitions for each entity in the codebase. Additionally, all entities have been updated with the correct fillable attributes based on the latest openapi.yml specification.
Details
Added property declarations for every entity to improve clarity and type safety.
Synced all entity fillable arrays with the current OpenAPI schema.
Ensures model definitions remain consistent with API contract changes.