Fix NewReader decompress that could lead to garbage data silently #231
Open
sidd1809 wants to merge 2 commits intopierrec:v4from
Open
Fix NewReader decompress that could lead to garbage data silently #231sidd1809 wants to merge 2 commits intopierrec:v4from
sidd1809 wants to merge 2 commits intopierrec:v4from
Conversation
Author
sidd1809
force-pushed
the
fix-decompress-reader-v4122
branch
from
a32014d to
264a5ae
Compare
Merged
Contributor
|
@sidd1809 the tests should be fixed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue starting in version:
v4.1.1 onwardsLast working Version:
v4.1.0We recently upgraded our lz4 library from
v2.6.1+incompatibletov4.1.22and started noticing data mismatch on decompression. Identified a missed edge-case handling where Decompress/Read patterns could return 0 data length, which currently ends up leaking a previously decompressed data frame buffer.Fix: Trim data frame buffer when it is by-passed for received buffer in a Read(recvBuf []byte) call.
Testing: