Add minimum distance option to clhs#24
Open
kdaust wants to merge 9 commits intopierreroudier:masterfrom
Open
Conversation
Contributor
|
Great idea! I can think of several use-cases here at USDA/NRCS. |
|
Hi @pierreroudier and @kdaust . Great work on this package. I was hoping to use the implementation of clhs with the minimum distance contained within this PR. It looks like it has stalled out and wondered if this PR is going to be reviewed and incorporated? I would prefer to point to the main clhs package rather than a fork if possible. Thanks in advance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @pierreroudier - Happy New Year! Some of the projects we've been using clhs for recently have required a minimum distance between sample points, so that transects don't overlap. I've implimented this into the C++ version; if the user inputs a two column table of coordinates and a minimum distance, then the algorithm adds a distance penalty to the objective function, as well as probabilistically swapping a point that is too close. It seems to work well, as long as there is enough space in the sample area. I could imagine this being a common use case - do you think it's worth pulling into the package?