Skip to content

Conversation

@codeZeilen
Copy link
Member

This PR speeds up PR builds by more than a minute if there are tests in the package and also makes coverage reporting reliable again:

  • Fixes the previously broken coverage. Coverage data was not reliably uploaded anymore, as codecov requires an organization token or else a global GH token is used. The covr::codecov call uses an old API that does not support organization tokens and thus we have also used the global GH token. We now use the codecov upload action with our organization token. To enable this, I needed to add a custom report format. In case Adds the simple codecov format to make using the codecov action easier r-lib/covr#616 is merged, we could replace this.
  • Limits coverage calc to main branches. We could simplify check.yml by introducing a separate coverage-reporting.yml that only execute coverage and only does so on the main branch. Not sure whether it is worth the effort yet to split up check.yml, given that it is somewhat small still.

Copy link
Contributor

@pascal-sauer pascal-sauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codeZeilen codeZeilen merged commit b50cf04 into pik-piam:master Sep 3, 2025
2 checks passed
@codeZeilen codeZeilen deleted the feature/coverage-limit-to-master branch September 3, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants