-
-
Notifications
You must be signed in to change notification settings - Fork 208
Custom auth flow support and OAuth2/OIDC plugin #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
intelfx
wants to merge
16
commits into
pikvm:master
Choose a base branch
from
intelfx:work/oauth
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b25f491 to
af1ed06
Compare
Add a sentinel marker `yamlconf.Dynamic()` that can be used as a schema key to signal a schema applying to an arbitrary number of keys at this level.
If the schema definition at a given level has a `Dynamic` marker key, validate every key that is not otherwise present in the schema against the definition of that key. Further down the line, we can make unexpected extra keys illegal, but for that we need to sanitize a;; existing uses of dynamic content.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preliminary implementation of a pluggable authentication flow architecture, with the OAuth/OAuth2 backend as the first user thereof.
Credits: #156
This implementation accepts configuration under the
kvmd.auth.flows.oauthkey, as follows:UI-wise, each provider corresponds to a separate button on the login page which triggers the corresponding auth flow.
API-wise, the new APIs are located under
/api/auth/flow/oauth/{key}. The name of a section underkvmd.auth.flows.oauth.providers(e.g.,githubormicrosoft) is an arbitrary URL-safe string, and it is used as the{key}in the base URL above.The callback URL will be
{pi-kvm}/api/auth/flow/oauth/{key}/callback. You will have to whitelist that URL in the OAuth authorization server in use.