Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,9 @@ function send (req, res, status, headers, message) {

// response status
res.statusCode = status
res.statusMessage = statuses.message[status]
if (req.httpVersionMajor < 2) {
res.statusMessage = statuses.message[status]
}

// remove any content headers
res.removeHeader('Content-Encoding')
Expand Down
41 changes: 41 additions & 0 deletions test/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -577,4 +577,45 @@ describe('finalhandler(req, res)', function () {
})
})
})

describe('HTTP/2', function () {
it('should respond 404 without warning', function (done) {
var warned = false
process.on('warning', function (warning) {
if (warning.name !== 'UnsupportedWarning') return
if (!warning.message.match(/Status message is not supported/)) return
warned = true
})

var http2
try {
http2 = require('http2')
} catch (e) {
return done()
}

var server = http2.createServer(function (req, res) {
var done = finalhandler(req, res)
done()
})

server.listen(0, function () {
var port = server.address().port
var client = http2.connect('http://localhost:' + port)
var req = client.request({
':method': 'GET',
':path': '/foo'
})

req.on('response', function (headers) {
assert.strictEqual(headers[':status'], 404)
req.close()
client.close()
server.close()
assert.strictEqual(warned, false)
done()
})
})
})
})
})