-
-
Notifications
You must be signed in to change notification settings - Fork 15
add type definitions #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Diluka
wants to merge
2
commits into
pillarjs:master
Choose a base branch
from
Diluka:feature/ship-typings
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
/** | ||
* Resolve a relative path against `process.cwd()` (the process's current working directory) and return an absolute path. This will throw if the resulting resolution seems malicious. The following are malicious: | ||
* | ||
* - The relative path is an absolute path | ||
* - The relative path contains a NULL byte | ||
* - The relative path resolves to a path outside of `process.cwd()` | ||
* - The relative path traverses above `process.cwd()` and back down | ||
* | ||
* @param {string} relativePath | ||
* @return {string} | ||
*/ | ||
declare function resolvePath(relativePath: string): string; | ||
|
||
/** | ||
* Resolve a relative path against the provided root path and return an absolute path. This will throw if the resulting resolution seems malicious. The following are malicious: | ||
* | ||
* - The relative path is an absolute path | ||
* - The relative path contains a NULL byte | ||
* - The relative path resolves to a path outside of the root path | ||
* - The relative path traverses above the root and back down | ||
* | ||
* @param {string} rootPath | ||
* @param {string} relativePath | ||
* @return {string} | ||
*/ | ||
declare function resolvePath(rootPath: string, relativePath: string): string; | ||
|
||
declare namespace resolvePath { | ||
} | ||
|
||
export = resolvePath; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do? Sorry not familiar with typings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's for typescript.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, but I mean what exactly does an empty namespace so for typescript?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the empty namespace will raise a type-check error in older version. It seems useless for current version. See the issue microsoft/TypeScript#5073
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, gotcha. I would have never known that, thank you. I would have accepted someone's PR removing it by accident. Can we add a test for this to prevent accidental removal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How to test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idk, I'm not familiar with typescript. That's why I'm asking you :) if you're not sure, do you know someone who may be who van come and help out here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/baryon/tracer
https://github.com/Microsoft/dtslint
found an example