Skip to content

Conversation

SenTzu01
Copy link

@SenTzu01 SenTzu01 commented Feb 4, 2018

Added feature allowing use of Pimatic functions and variables in custom Player.Open commands

…urrentArtist() causes Pimatic to crash while attempting to insert attribute value into the database

Plugin only checked for key not null, should check for array not empty
@SenTzu01
Copy link
Author

This also inlcudes changes from the previous pull request. only line 277 is of interest for the bugfix

@SenTzu01 SenTzu01 closed this Apr 28, 2018
@SenTzu01 SenTzu01 reopened this Apr 28, 2018
Copy link
Collaborator

@mwittig mwittig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the suggested code changes: 'lenght ' should read 'length'. Besides are you sure it should be info.artist[0] which is the first character of the string or the first element of the array (if I remember correctly, the artist is given as string, but may be I am wrong). EDIT: I didn't read the commit message text. It is indicating that the artist is given as an arry in some case - do you think this this might depend on the play being used in Kodi? What did you play when the issue popped up?

@SenTzu01
Copy link
Author

Hi Marcus,

Been a while since that request. I have corrected the typo and will resubmit. The [0] refers to the first array element if remember correctly, as during debug output I noticed an array was returned. I tested against the below OSMC version:

grep Kodi .kodi/temp/kodi.log | head -3
19:05:14.549 T:1925646848 NOTICE: Starting Kodi (17.6). Platform: Linux ARM (Thumb) 32-bit
19:05:14.549 T:1925646848 NOTICE: Using Release Kodi x32 build (version for Raspberry Pi)
19:05:14.549 T:1925646848 NOTICE: Kodi compiled Feb 7 2018 by GCC 6.3.0 for Linux ARM (Thumb) 32-bit version 4.9.30 (264478)

@SenTzu01
Copy link
Author

Additional change to remove predicates. Will open another PR on Pimatic as the predicates have been added to core relating to AVPlayer parent class. Pimatic-Spotify also inherits this class and have a predicate collision if it is not moved up the chain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants