Override default keybinding for cmd-enter#53
Open
kylebarron wants to merge 2 commits intopimentel:masterfrom
Open
Override default keybinding for cmd-enter#53kylebarron wants to merge 2 commits intopimentel:masterfrom
kylebarron wants to merge 2 commits intopimentel:masterfrom
Conversation
Owner
|
fantastic. thanks, @kylebarron! going to test this out and merge later this week. |
Author
|
Also, thanks for the awesome package! It was really easy to port all the functionality to running code in Stata. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought it was weird that you'd need to manually add something to your keymap.cson to use
cmd-enter, because I use the Hydrogen package often and I never had to edit the keymap to usecmd-enterwith that package.Looking at Hydrogen's keymap.cson, the included changes should force the use of
cmd-enterfor this package. I've also added[data-grammar="source r"]because it's likely anyone using this package would only be using it for files covered by the R grammar file, but you could take that out if you want.I believe this could fix #52 and #51.