Integration of an optimised Hub75 driver#1084
Open
JuPfu wants to merge 1 commit intopimoroni:mainfrom
Open
Conversation
…he changes can be found in https://github.com/JuPfu/hub75. Additional resulting changes: -user implemented interrupt callback function dma_complete() not requiered any more - this implies some minor changes in the api. The old api is still valid but designated as deprecated
Author
|
Hello, the pull request seems to be stalled. Is there anything to do from my side to have the pull request continued ? |
Member
|
Sorry I had meant to reply, but I'm too easily distracted 😬 Briefly it's too big a change to too critical a function and I don't have the bandwidth to properly test and respond to it right now. It also correlates with some related products in the pipeline which involves us looking over this code and potentially making more significant performance improvements and other changes In the near term it's very much an "if it ain't broke, don't fix it" thing. Sorry! Appreciate the effort to make these changes and follow up nonetheless. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In depth documentation of the changes can be found in https://github.com/JuPfu/hub75.
Additional resulting changes:
-user implemented interrupt callback function dma_complete() not requiered any more