QA: Fix module checks and fix modules.

Author: Gadgetoid

ci/python.sh

@@ -28,9 +28,9 @@ function qa_examples_fix {
 }
 
 function qa_modules_check {
-    ruff check --select "$QA_INCLUDE" examples/ --ignore "$QA_IGNORE"
+    ruff check --select "$QA_INCLUDE" modules/py_frozen --ignore "$QA_IGNORE"
 }
 
 function qa_modules_fix {
-    ruff check --select "$QA_INCLUDE" examples/ --ignore "$QA_IGNORE" --fix
+    ruff check --select "$QA_INCLUDE" modules/py_frozen --ignore "$QA_IGNORE" --fix
 }

modules/py_frozen/ezwifi.py

@@ -110,8 +110,8 @@ def _secrets(self):
             if not WIFI_PASSWORD:
                 raise ValueError("secrets.py: WIFI_PASSWORD is empty!")
             return WIFI_SSID, WIFI_PASSWORD
-        except ImportError:
-            raise ImportError("secrets.py: missing or invalid!")
+        except ImportError as err:
+            raise ImportError("secrets.py: missing or invalid!") from err
 
 
 def connect(**kwargs):

modules/py_frozen/lsm6ds3.py

@@ -108,9 +108,7 @@ def get_step_count(self):
 
         data = self._read_reg(STEP_COUNTER_L, 2)
         steps = (data[1] << 8) | data[0]
-        steps = twos_comp(steps)
-
-        return steps
+        return twos_comp(steps)
 
     def reset_step_count(self):
 
@@ -122,34 +120,24 @@ def reset_step_count(self):
     def tilt_detected(self):
 
         tilt = self._read_reg(FUNC_SRC1, 1)
-        tilt = (tilt[0] >> 5) & 0b1
-
-        return tilt
+        return (tilt[0] >> 5) & 0b1
 
     def sig_motion_detected(self):
 
         sig = self._read_reg(FUNC_SRC1, 1)
-        sig = (sig[0] >> 6) & 0b1
-
-        return sig
+        return (sig[0] >> 6) & 0b1
 
     def single_tap_detected(self):
 
         s = self._read_reg(TAP_SRC, 1)
-        s = (s[0] >> 5) & 0b1
-
-        return s
+        return (s[0] >> 5) & 0b1
 
     def double_tap_detected(self):
 
         d = self._read_reg(TAP_SRC, 1)
-        d = (d[0] >> 4) & 0b1
-
-        return d
+        return (d[0] >> 4) & 0b1
 
     def freefall_detected(self):
 
         fall = self._read_reg(WAKE_UP_SRC, 1)
-        fall = fall[0] >> 5
-
-        return fall
+        return fall[0] >> 5

modules/py_frozen/psram.py

@@ -68,6 +68,7 @@ def ioctl(self, op, arg):
         if op == 6:  # Erase
             # We don't really *need* to erase blocks but should we?
             return 0
+        return None
 
 
 def mkramfs(size=1024 * 64, mount_point="/ramfs", debug=False):

modules/py_frozen/touch.py

@@ -60,7 +60,7 @@ def __init__(self, full_res=False, enable_interrupt=False):
 
     def poll(self):
         if self._irq:
-            return None
+            return
 
         if not self._touch_int.value() or self.state or self.state2:
             self._handle_touch(self._touch_int)
@@ -71,7 +71,7 @@ def _read_touch(self, data):
         y = ((data[2] & 0x0f) << 8) | data[3]
         return int(x / self._scale), int(y / self._scale), e not in (self.STATE_NONE, self.STATE_UP)
 
-    def _handle_touch(self, pin):
+    def _handle_touch(self, pin):  # noqa ARG002
         self.state = self.state2 = False
 
         self._i2c.writeto(self.TOUCH_ADDR, b"\x00", False)