Skip to content

Support custom AMI#19

Merged
benny-n merged 5 commits intomainfrom
johnnie/support-custom-ami
Feb 16, 2026
Merged

Support custom AMI#19
benny-n merged 5 commits intomainfrom
johnnie/support-custom-ami

Conversation

@chunglu-chou
Copy link
Collaborator

@chunglu-chou chunglu-chou commented Feb 14, 2026

Problem

Toyota

Solution

Support custom AMI when specified.
Need the base64 encoded user data for nodeadm to kick in and join the cluster if using custom AMI. Also export it to pulumi output so dynamic node pool charts can take from there.

Reference: https://awslabs.github.io/amazon-eks-ami/nodeadm/

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Describe specific steps for validating this change.


Note

Medium Risk
Changes EKS nodegroup provisioning/bootstrapping when custom_ami_id is set, which can prevent nodes from joining if the AMI or user data is incorrect; default behavior remains unchanged when unset.

Overview
Adds optional custom_ami_id support to AWS BYOC configuration and cluster args, wiring it through to EKS node group launch templates.

When a custom AMI is provided, EKS now generates base64-encoded nodeadm bootstrap user_data, sets the launch template image_id, and switches nodegroups to ami_type="CUSTOM"; the encoded user data and custom_ami_id are also surfaced in Pulumi outputs for downstream consumers.

Updates the AWS setup wizard to prompt for (or read PINECONE_CUSTOM_AMI_ID) and persist custom-ami-id into the generated Pulumi stack config and __main__.py args.

Written by Cursor Bugbot for commit 82d97a1. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@benny-n benny-n merged commit 20e4d5b into main Feb 16, 2026
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants