public ALB for aws + AMP unification + private endpoint output#21
Merged
public ALB for aws + AMP unification + private endpoint output#21
Conversation
hanik-m
approved these changes
Feb 19, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches networking/ingress and cloud IAM/AMP wiring across AWS/Azure/GCP, which can affect cluster reachability and metrics auth if misconfigured, but changes are mostly additive and feature-gated.
Overview
Adds an optional internet-facing AWS ALB (HTTP1 + HTTP2 ingresses) alongside the existing private NLB/PrivateLink path, gated by
public_access_enabled, and creates a Route53 alias foringress.{fqdn}to the public ALB.Unifies cross-cloud AMP configuration to always provision
AmpAccessfor Azure/GCP and switches the workload trust to theAmpCpgwIamManagerUserIAM user; cluster stacks now export private connectivity identifiers when public access is disabled (vpc_endpoint_service_name,psc_service_attachment,private_link_service_name/resource group).Refactors
Pinetoolsto expose created K8s resources (ns,sa,crb) for dependency ordering, updates uninstallers to depend on these, and changes AWS S3 bucket versioning to use the dedicatedBucketVersioningresource. The setup wizard bumps the default Pinecone version and improves GCP preflight by requiringgke-gcloud-auth-plugin.Written by Cursor Bugbot for commit d3d34a4. This will update automatically on new commits. Configure here.