Skip to content

added flush log backup tasks#2718

Merged
ti-chi-bot[bot] merged 6 commits intopingcap:masterfrom
YuJuncen:add-graceful-flush
Mar 5, 2025
Merged

added flush log backup tasks#2718
ti-chi-bot[bot] merged 6 commits intopingcap:masterfrom
YuJuncen:add-graceful-flush

Conversation

@YuJuncen
Copy link
Copy Markdown
Contributor

@YuJuncen YuJuncen commented Mar 5, 2025 •
edited by BornChanger
Loading

First-time contributors' checklist

What is changed, added, or deleted? (Required)

增加了优雅重启关于 Flush Log Backup 的部分。
Added description of auto flushing log backup when doing graceful restarting.

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v1.6 (TiDB Operator 1.6 versions)
  • v1.5 (TiDB Operator 1.5 versions)
  • v1.4 (TiDB Operator 1.4 versions)
  • v1.3 (TiDB Operator 1.3 versions)

What is the related PR or file link(s)?

@ti-chi-bot ti-chi-bot bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Mar 5, 2025
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 5, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 5, 2025
BornChanger
BornChanger reviewed Mar 5, 2025
View reviewed changes
@YuJuncen @BornChanger
Apply suggestions from code review
aa9b68f 
Co-authored-by: BornChanger <97348524+BornChanger@users.noreply.github.com>
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Mar 5, 2025

@BornChanger: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lilin90 lilin90 added needs-cherry-pick-release-1.5 Should cherry pick this PR to release-1.5 branch. needs-cherry-pick-release-1.6 Should cherry pick this PR to release-1.6 branch. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. labels Mar 5, 2025
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Mar 5, 2025
@lilin90 lilin90 requested a review from Oreoxmt March 5, 2025 09:26
Oreoxmt
Oreoxmt approved these changes Mar 5, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Mar 5, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-05 09:36:30.727207013 +0000 UTC m=+434303.856126752: ☑️ agreed by Oreoxmt.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 5, 2025
BornChanger and others added 2 commits March 5, 2025 17:44
@BornChanger @Oreoxmt
Update zh/restart-a-tidb-cluster.md
75f5129 
Co-authored-by: Aolin <aolinz@outlook.com>
@BornChanger @Oreoxmt
Update en/restart-a-tidb-cluster.md
bc50891 
Co-authored-by: Aolin <aolinz@outlook.com>
@Oreoxmt
Copy link
Copy Markdown
Collaborator

Oreoxmt commented Mar 5, 2025

/approve

BornChanger
BornChanger reviewed Mar 5, 2025
View reviewed changes
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Mar 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 5, 2025
@Oreoxmt Oreoxmt added the lgtm label Mar 5, 2025
@ti-chi-bot ti-chi-bot bot merged commit 82fc2e3 into pingcap:master Mar 5, 2025
14 checks passed
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 5, 2025
Merged
6 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Mar 5, 2025

In response to a cherrypick label: new pull request created to branch release-1.6: #2719.

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Mar 5, 2025

In response to a cherrypick label: new pull request created to branch release-1.5: #2720.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 5, 2025
Merged
6 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Mar 5, 2025
@ti-chi-bot
added flush log backup tasks (#2718) (#2720)
7db18e6
ti-chi-bot bot pushed a commit that referenced this pull request Mar 5, 2025
@ti-chi-bot
added flush log backup tasks (#2718) (#2719)
f7f2726
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BornChanger BornChanger BornChanger approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels

approved first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-1.5 Should cherry pick this PR to release-1.5 branch. needs-cherry-pick-release-1.6 Should cherry pick this PR to release-1.6 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@YuJuncen @CLAassistant @Oreoxmt @ti-chi-bot @BornChanger @lilin90