tikv-configuration-file: update flow-control override behavior for v8.5.5 (#22296) #22310
+18
−4
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -570,12 +570,22 @@ Configuration items related to the flow control mechanism in TiKV. This mechanis | |||||
|
|
||||||
| ### `l0-files-threshold` | ||||||
|
|
||||||
| + When the number of kvDB L0 files reaches this threshold, the flow control mechanism starts to work. | ||||||
|
|
||||||
| > **Note:** | ||||||
| > | ||||||
| > Under specific conditions, this configuration item can override the value of `rocksdb.(defaultcf|writecf|lockcf|raftcf).level0-slowdown-writes-trigger`. For more information, see [`rocksdb.(defaultcf|writecf|lockcf|raftcf).level0-slowdown-writes-trigger`](/tikv-configuration-file.md#level0-slowdown-writes-trigger). | ||||||
|
|
||||||
| + Default value: `20` | ||||||
|
|
||||||
| ### `soft-pending-compaction-bytes-limit` | ||||||
|
|
||||||
| + When the pending compaction bytes in KvDB reach this threshold, the flow control mechanism starts to reject some write requests and reports the `ServerIsBusy` error. | ||||||
|
|
||||||
| > **Note:** | ||||||
| > | ||||||
| > Under specific conditions, this configuration item can override the value of `rocksdb.(defaultcf|writecf|lockcf|raftcf).soft-pending-compaction-bytes-limit`. For more information, see [`rocksdb.(defaultcf|writecf|lockcf|raftcf).soft-pending-compaction-bytes-limit`](/tikv-configuration-file.md#soft-pending-compaction-bytes-limit-1). | ||||||
|
|
||||||
| + Default value: `"192GiB"` | ||||||
|
|
||||||
| ### `hard-pending-compaction-bytes-limit` | ||||||
|
|
@@ -1638,7 +1648,9 @@ Configuration items related to `rocksdb.defaultcf`, `rocksdb.writecf`, and `rock | |||||
|
|
||||||
| ### `level0-slowdown-writes-trigger` | ||||||
|
|
||||||
| + The maximum number of files at L0 that trigger write stall. | ||||||
| + In v8.5.4 and earlier versions: when the flow control mechanism is enabled ([`storage.flow-control.enable`](/tikv-configuration-file.md#enable) is `true`), the value of this configuration item is directly overridden by [`storage.flow-control.l0-files-threshold`](/tikv-configuration-file.md#l0-files-threshold). | ||||||
| + Starting from v8.5.5 and v9.0.0: when the flow control mechanism is enabled ([`storage.flow-control.enable`](/tikv-configuration-file.md#enable) is `true`), the value of this configuration item is overridden by [`storage.flow-control.l0-files-threshold`](/tikv-configuration-file.md#l0-files-threshold) only when its value is greater than `storage.flow-control.l0-files-threshold`. This behavior prevents weakening RocksDB's compaction acceleration mechanism when you increase the flow control threshold. | ||||||
| + Default value: `20` | ||||||
| + Minimum value: `0` | ||||||
|
|
||||||
|
|
@@ -1694,7 +1706,9 @@ Configuration items related to `rocksdb.defaultcf`, `rocksdb.writecf`, and `rock | |||||
|
|
||||||
| ### `soft-pending-compaction-bytes-limit` | ||||||
|
|
||||||
| + The soft limit on the pending compaction bytes. | ||||||
| + In v8.5.4 and earlier versions: when the flow control mechanism is enabled ([`storage.flow-control.enable`](/tikv-configuration-file.md#enable) is `true`), this configuration item is directly overridden by [`storage.flow-control.soft-pending-compaction-bytes-limit`](/tikv-configuration-file.md#soft-pending-compaction-bytes-limit). | ||||||
| + Starting from v8.5.5 and v9.0.0: when the flow control mechanism is enabled ([`storage.flow-control.enable`](/tikv-configuration-file.md#enable) is `true`), this configuration item is overridden by [`storage.flow-control.soft-pending-compaction-bytes-limit`](/tikv-configuration-file.md#soft-pending-compaction-bytes-limit) only when its value is greater than `storage.flow-control.soft-pending-compaction-bytes-limit`. This behavior prevents weakening RocksDB's compaction acceleration mechanism when you increase the flow control threshold. | ||||||
|
Contributor
There was a problem hiding this comment. To improve clarity, especially since the two parameter names are very similar, I suggest rephrasing this sentence to explain what the effective value will be. This avoids a potentially confusing self-reference and makes the behavior easier for users to understand.
Suggested change
References
|
||||||
| + Default value: `"192GiB"` | ||||||
| + Unit: KiB|MiB|GiB | ||||||
|
|
||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To improve clarity, I suggest rephrasing this sentence to explain what the effective value will be. This avoids a potentially confusing self-reference and makes the behavior easier for users to understand.
References