cloud: update features and select-cluster tier for Premium#22638
cloud: update features and select-cluster tier for Premium#22638qqqdan wants to merge 6 commits intofeature/preview-premiumfrom
Conversation
ti-chi-bot
Bot
added
missing-translation-status
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the new Premium plan to TiDB Cloud documentation. Key changes include adding a Premium column to the feature support table, providing a detailed description of the plan's benefits, and updating its status to public preview. Review feedback suggests verifying a potential status regression for database audit logging and recommends rewriting feature descriptions to use the second person and active voice for improved clarity.
| <td>Database audit logging</td> | ||
| <td style="text-align:center; font-size: 14px;">❌</td> | ||
| <td style="text-align:center;">🔒</td> | ||
| <td style="text-align:center;">🚧</td> |
There was a problem hiding this comment.
The status for "Database audit logging" on the Essential plan has changed from 🔒 (private preview) to 🚧 (under development). This seems like a feature regression. Could you please confirm if this change is intentional? According to the legend, 🚧 means "under development", which is usually a step before "private preview".
References
- The style guide requires technical accuracy. The change from 'private preview' to 'under development' for a feature seems to be a regression and might be technically inaccurate. (link)
Oreoxmt
added
translation/no-need
ti-chi-bot
Bot
removed
the
missing-translation-status
Oreoxmt
changed the title
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Oreoxmt
force-pushed
the
premium-public-review
branch
from
b66ef93 to
50d629e
Compare
Co-authored-by: Aolin <aolinz@outlook.com>
| <td style="text-align:center;">✅ <br/><span style="font-size: 14px; white-space: nowrap;">(Public preview)</span></td> | ||
| <td style="text-align:center;">✅ <br/><span style="font-size: 14px; white-space: nowrap;">(Public preview)</span></td> | ||
| <td style="text-align:center;">🚧</td> | ||
| <td style="text-align:center;">🚧</td> |
There was a problem hiding this comment.
Does it mean TiDB Cloud Dedicated does not support vector search now? Currently, we already have some notes similar to the one below in our docs.
ti-chi-bot
Bot
added
lgtm
and removed
needs-1-more-lgtm
Co-authored-by: Grace Cai <qqzczy@126.com>
Oreoxmt
force-pushed
the
premium-public-review
branch
from
0ec8774 to
ad7881c
Compare
3 participants
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?