Skip to content

cloud: update public endpoint firewall steps#22807

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:release-8.5from
qiancai:update-public-endpoint-steps
Apr 29, 2026
Merged

cloud: update public endpoint firewall steps#22807
ti-chi-bot[bot] merged 4 commits intopingcap:release-8.5from
qiancai:update-public-endpoint-steps

Conversation

@qiancai
Copy link
Copy Markdown
Collaborator

@qiancai qiancai commented Apr 27, 2026

What is changed, added or deleted? (Required)

  • Update Starter/Essential firewall rule steps for public endpoints, including deleting the default Allow_all_public_connections rule, adding current IP/AWS access/address ranges, and saving changes.
  • Update the TiCDC migration guide to distinguish Starter/Essential firewall rules from Dedicated IP access list steps.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Validation

  • git diff --check

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 27, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 27, 2026
@qiancai qiancai self-assigned this Apr 27, 2026
@qiancai qiancai added area/tidb-cloud This PR relates to the area of TiDB Cloud. for-cloud-release This PR is related to TiDB Cloud release. cherry-pick-release-cloud/no-need No need to cherry pick this PR to the "release-cloud" branch. and removed missing-translation-status This PR does not have translation status info. labels Apr 27, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Apr 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the TiDB Cloud documentation for configuring firewall rules and migrating from on-premises TiDB. The changes include new instructions for managing default public connections, documentation for the 'Add AWS Access' feature, and plan-specific networking steps for TiCDC replication. Review feedback identifies a missing preposition, suggests moving punctuation outside of quotation marks for search queries, and recommends using active voice instead of passive voice to align with the style guide.

Comment thread tidb-cloud/migrate-from-op-tidb.md Outdated
Comment thread tidb-cloud/configure-serverless-firewall-rules-for-public-endpoints.md Outdated
Comment thread tidb-cloud/configure-serverless-firewall-rules-for-public-endpoints.md Outdated
qiancai and others added 2 commits April 27, 2026 13:48
@qiancai @gemini-code-assist
Apply suggestions from code review
bb0d79d 
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@qiancai @gemini-code-assist
Update tidb-cloud/migrate-from-op-tidb.md
454ca80 
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
sanshuiyijing
sanshuiyijing approved these changes Apr 27, 2026
View reviewed changes
Copy link
Copy Markdown

@sanshuiyijing sanshuiyijing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 27, 2026

@sanshuiyijing: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@qiancai qiancai marked this pull request as ready for review April 27, 2026 06:11
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 27, 2026
@Oreoxmt
Copy link
Copy Markdown
Collaborator

Oreoxmt commented Apr 27, 2026

/cc @Oreoxmt

@ti-chi-bot ti-chi-bot Bot requested a review from Oreoxmt April 27, 2026 06:14
Oreoxmt
Oreoxmt reviewed Apr 27, 2026
View reviewed changes
Comment thread tidb-cloud/migrate-from-op-tidb.md Outdated
Oreoxmt
Oreoxmt reviewed Apr 27, 2026
View reviewed changes
Comment thread tidb-cloud/migrate-from-op-tidb.md Outdated
Oreoxmt
Oreoxmt reviewed Apr 27, 2026
View reviewed changes
Comment thread tidb-cloud/configure-serverless-firewall-rules-for-public-endpoints.md Outdated
Oreoxmt
Oreoxmt reviewed Apr 27, 2026
View reviewed changes
Comment thread tidb-cloud/configure-serverless-firewall-rules-for-public-endpoints.md Outdated
Oreoxmt
Oreoxmt reviewed Apr 27, 2026
View reviewed changes
Comment thread tidb-cloud/configure-serverless-firewall-rules-for-public-endpoints.md Outdated
Oreoxmt
Oreoxmt reviewed Apr 27, 2026
View reviewed changes
Comment thread tidb-cloud/configure-serverless-firewall-rules-for-public-endpoints.md Outdated
Oreoxmt
Oreoxmt reviewed Apr 27, 2026
View reviewed changes
Comment thread tidb-cloud/configure-serverless-firewall-rules-for-public-endpoints.md Outdated
Oreoxmt
Oreoxmt approved these changes Apr 27, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 27, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 27, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-04-27 11:04:44.958423591 +0000 UTC m=+2595890.163783658: ☑️ agreed by Oreoxmt.

@qiancai @Oreoxmt
Apply suggestions from code review
a393aff 
Co-authored-by: Aolin <aolinz@outlook.com>
@qiancai qiancai added the lgtm label Apr 29, 2026
@qiancai
Copy link
Copy Markdown
Collaborator Author

qiancai commented Apr 29, 2026

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 29, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Apr 29, 2026
@ti-chi-bot ti-chi-bot Bot merged commit 5a72128 into pingcap:release-8.5 Apr 29, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

+2 more reviewers

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

@sanshuiyijing sanshuiyijing sanshuiyijing approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@qiancai qiancai

Labels

approved area/tidb-cloud This PR relates to the area of TiDB Cloud. cherry-pick-release-cloud/no-need No need to cherry pick this PR to the "release-cloud" branch. for-cloud-release This PR is related to TiDB Cloud release. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@qiancai @Oreoxmt @sanshuiyijing