ddl: disable wait Async DDL Done (#3330)

ref #3329

Author: hongyunyan

pkg/sink/mysql/mysql_writer.go

@@ -109,10 +109,10 @@ func (w *Writer) SetTableSchemaStore(tableSchemaStore *util.TableSchemaStore) {
 }
 
 func (w *Writer) FlushDDLEvent(event *commonEvent.DDLEvent) error {
-	if w.cfg.IsTiDB {
-		// first we check whether there is some async ddl executed now.
-		w.waitAsyncDDLDone(event)
-	}
+	// if w.cfg.IsTiDB {
+	// 	// first we check whether there is some async ddl executed now.
+	// 	w.waitAsyncDDLDone(event)
+	// }
 	if w.cfg.IsTiDB || !event.TiDBOnly {
 		// we write ddl ts before ddl first, and update the ddl ts item after ddl executed,
 		// to ensure the atomic with ddl writing when server is restarted.

pkg/sink/mysql/mysql_writer_test.go

@@ -21,17 +21,14 @@ import (
 	"time"
 
 	"github.com/DATA-DOG/go-sqlmock"
-	"github.com/go-sql-driver/mysql"
 	lru "github.com/hashicorp/golang-lru"
 	"github.com/pingcap/errors"
-	"github.com/pingcap/log"
 	"github.com/pingcap/ticdc/heartbeatpb"
 	"github.com/pingcap/ticdc/pkg/common"
 	commonEvent "github.com/pingcap/ticdc/pkg/common/event"
 	cerror "github.com/pingcap/ticdc/pkg/errors"
 	"github.com/pingcap/ticdc/pkg/metrics"
 	"github.com/pingcap/ticdc/pkg/sink/util"
-	timodel "github.com/pingcap/tidb/pkg/meta/model"
 	"github.com/pingcap/tidb/pkg/sessionctx/variable"
 	"github.com/stretchr/testify/require"
 )
@@ -434,6 +431,7 @@ func TestMysqlWriter_RemoveDDLTsTable(t *testing.T) {
 	require.NoError(t, err)
 }
 
+/*
 // Test the async ddl can be write successfully
 func TestMysqlWriter_AsyncDDL(t *testing.T) {
 	writer, db, mock := newTestMysqlWriterForTiDB(t)
@@ -622,6 +620,7 @@ func TestMysqlWriter_AsyncDDL(t *testing.T) {
 	err = mock.ExpectationsWereMet()
 	require.NoError(t, err)
 }
+*/
 
 func TestCheckIsDuplicateEntryError(t *testing.T) {
 	writer, db, _ := newTestMysqlWriter(t)

tests/integration_tests/run_heavy_it_in_ci.sh

@@ -52,7 +52,8 @@ mysql_groups=(
 	'resolve_lock merge_table drop_many_tables'
 	# G10
 	# 'consistent_replicate_nfs consistent_replicate_storage_file consistent_replicate_storage_file_large_value consistent_replicate_storage_s3'
-	'multi_changefeeds ddl_wait'
+	# 'multi_changefeeds ddl_wait'
+	'multi_changefeeds'
 	# G11
 	'ddl_reentrant force_replicate_table multi_source'
 	# G12