Skip to content

metrics: add ddl count for different ddl type #3833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ti-chi-bot merged 19 commits into from
Jan 16, 2026
Merged

metrics: add ddl count for different ddl type #3833

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
3373598
init
wk989898 Dec 29, 2025
f5893fe
update
wk989898 Dec 29, 2025
d7eefed
update
wk989898 Dec 29, 2025
f04cf30
chore
wk989898 Dec 29, 2025
47a9bd8
update
wk989898 Dec 29, 2025
cecc3e8
update metric
wk989898 Dec 29, 2025
f506d32
chore
wk989898 Dec 29, 2025
33957e3
update
wk989898 Dec 29, 2025
0e7a3ee
update
wk989898 Dec 29, 2025
4e3e11e
chore
wk989898 Dec 29, 2025
5d1b94c
update
wk989898 Dec 30, 2025
03c948f
chore
wk989898 Jan 5, 2026
9a31b03
Update pkg/metrics/statistics.go
hongyunyan Jan 6, 2026
b1fab4f
update
wk989898 Jan 6, 2026
cd0c8f8
Merge branch 'ddl-metrics' of https://github.com/wk989898/ticdc into …
wk989898 Jan 6, 2026
bfc7263
Update pkg/metrics/statistics.go
wk989898 Jan 12, 2026
c17d5c7
Merge branch 'master' into ddl-metrics
wk989898 Jan 13, 2026
0705666
update
wk989898 Jan 13, 2026
734fee4
fix data race
wk989898 Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion downstreamadapter/sink/cloudstorage/sink.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,8 @@ func (s *sink) writeFile(v *commonEvent.DDLEvent, def cloudstorage.TableDefiniti
}
log.Debug("write ddl event to external storage",
zap.String("path", path), zap.Any("ddl", v))
return s.statistics.RecordDDLExecution(func() error {
ddlType := v.GetDDLType().String()
return s.statistics.RecordDDLExecution(ddlType, func() error {
err = s.storage.WriteFile(s.ctx, path, encodedDef)
if err != nil {
return err
Expand Down
5 changes: 3 additions & 2 deletions downstreamadapter/sink/kafka/sink.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,12 +429,13 @@ func (s *sink) sendDDLEvent(event *commonEvent.DDLEvent) error {
if err != nil {
return err
}
ddlType := e.GetDDLType().String()
if s.partitionRule == helper.PartitionAll {
err = s.statistics.RecordDDLExecution(func() error {
err = s.statistics.RecordDDLExecution(ddlType, func() error {
return s.ddlProducer.SendMessages(topic, partitionNum, message)
})
} else {
err = s.statistics.RecordDDLExecution(func() error {
err = s.statistics.RecordDDLExecution(ddlType, func() error {
return s.ddlProducer.SendMessage(topic, 0, message)
})
}
Expand Down
5 changes: 3 additions & 2 deletions downstreamadapter/sink/pulsar/sink.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,12 +162,13 @@ func (s *sink) sendDDLEvent(event *commonEvent.DDLEvent) error {
if err != nil {
return err
}
ddlType := e.GetDDLType().String()
if s.partitionRule == helper.PartitionAll {
err = s.statistics.RecordDDLExecution(func() error {
err = s.statistics.RecordDDLExecution(ddlType, func() error {
return s.ddlProducer.syncBroadcastMessage(s.ctx, topic, message)
})
} else {
err = s.statistics.RecordDDLExecution(func() error {
err = s.statistics.RecordDDLExecution(ddlType, func() error {
return s.ddlProducer.syncSendMessage(s.ctx, topic, message)
})
}
Expand Down
3 changes: 2 additions & 1 deletion downstreamadapter/sink/redo/sink.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,8 @@ func (s *Sink) Run(ctx context.Context) error {
func (s *Sink) WriteBlockEvent(event commonEvent.BlockEvent) error {
switch e := event.(type) {
case *commonEvent.DDLEvent:
err := s.statistics.RecordDDLExecution(func() error {
ddlType := e.GetDDLType().String()
err := s.statistics.RecordDDLExecution(ddlType, func() error {
return s.ddlWriter.WriteEvents(s.ctx, e)
})
if err != nil {
Expand Down
Loading