Skip to content

Add a feature gate to use PD's ready API as the readiness probe#6282

Merged
ti-chi-bot[bot] merged 15 commits intopingcap:feature/v2from
fgksgf:huaxi/pd-ready
Jul 9, 2025
Merged

Add a feature gate to use PD's ready API as the readiness probe#6282
ti-chi-bot[bot] merged 15 commits intopingcap:feature/v2from
fgksgf:huaxi/pd-ready

Conversation

@fgksgf
Copy link
Copy Markdown
Member

@fgksgf fgksgf commented Jul 4, 2025

What problem does this PR solve?

Port #6243
Close #6244

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot ti-chi-bot bot requested a review from shonge July 4, 2025 06:40
@github-actions github-actions bot added the v2 for operator v2 label Jul 4, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 4, 2025

/run-pull-e2e-kind-v2

@ti-chi-bot ti-chi-bot bot added the size/XL label Jul 4, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 4, 2025

Codecov Report

❌ Patch coverage is 36.36364% with 56 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.98%. Comparing base (5ab4e8f) to head (743c507).
⚠️ Report is 108 commits behind head on feature/v2.

Additional details and impacted files
@@              Coverage Diff               @@
##           feature/v2    #6282      +/-   ##
==============================================
- Coverage       46.02%   45.98%   -0.04%     
==============================================
  Files             304      304              
  Lines           20054    20135      +81     
==============================================
+ Hits             9230     9260      +30     
- Misses          10824    10875      +51     
Flag Coverage Δ
unittest 45.98% <36.36%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 4, 2025

/run-pull-e2e-kind-v2

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 7, 2025

/run-pull-e2e-kind-v2

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 8, 2025

/run-pull-e2e-kind-v2

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 8, 2025

/run-pull-e2e-kind-v2

@liubog2008
Copy link
Copy Markdown
Member

/test ?

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Jul 8, 2025

@liubog2008: The following commands are available to trigger optional jobs:

/test pull-e2e
Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@liubog2008
Copy link
Copy Markdown
Member

/test pull-e2e

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Jul 8, 2025

@fgksgf: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-e2e 97aa107 link false /test pull-e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 8, 2025

/run-pull-e2e-kind-v2

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 9, 2025

/run-pull-e2e-kind-v2

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 9, 2025

/run-pull-e2e-kind-v2

@ti-chi-bot ti-chi-bot bot added size/XXL and removed size/XL labels Jul 9, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 9, 2025

/run-pull-e2e-kind-v2

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 9, 2025

/run-pull-e2e-kind-v2

@ti-chi-bot ti-chi-bot bot added size/XL and removed size/XXL labels Jul 9, 2025
@fgksgf
Copy link
Copy Markdown
Member Author

fgksgf commented Jul 9, 2025

/run-pull-e2e-kind-v2

@liubog2008
Copy link
Copy Markdown
Member

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 9, 2025
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Jul 9, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-07-09 12:07:06.831140005 +0000 UTC m=+2087879.554318988: ☑️ agreed by liubog2008.

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Jul 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liubog2008

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 9, 2025
@ti-chi-bot ti-chi-bot bot merged commit c4fedd2 into pingcap:feature/v2 Jul 9, 2025
9 checks passed
liubog2008 pushed a commit to liubog2008/tidb-operator that referenced this pull request Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants