-
Notifications
You must be signed in to change notification settings - Fork 522
feat: add resource-manager support to PD microservices #6635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: okjiang <[email protected]>
Signed-off-by: okjiang <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6635 +/- ##
==========================================
- Coverage 39.33% 38.10% -1.24%
==========================================
Files 351 367 +16
Lines 20665 21341 +676
==========================================
+ Hits 8129 8132 +3
- Misses 12536 13209 +673
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
| Hostname: coreutil.PodName[scope.ResourceManager](rm), | ||
| Subdomain: rm.Spec.Subdomain, | ||
| NodeSelector: rm.Spec.Topology, | ||
| Containers: []corev1.Container{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a readiness probe.
|
add this component into the case in |
Signed-off-by: okjiang <[email protected]>
Signed-off-by: okjiang <[email protected]>
Signed-off-by: okjiang <[email protected]>
Signed-off-by: okjiang <[email protected]>
Signed-off-by: okjiang <[email protected]>
Signed-off-by: okjiang <[email protected]>
Signed-off-by: okjiang <[email protected]>
Signed-off-by: okjiang <[email protected]>
api/meta/v1alpha1/feature.go
Outdated
| UseSchedulingReadyAPI Feature = "UseSchedulingReadyAPI" | ||
| UseSchedulingReadyAPIStage FeatureStage = FeatureStageAlpha | ||
|
|
||
| // UseResourceManagerReadyAPI calls /health api to check readiness for resource manager pods. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to add a new feature gates for a new compnent
Signed-off-by: okjiang <[email protected]>
Signed-off-by: okjiang <[email protected]>
|
@okJiang: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.