Skip to content

Conversation

@okJiang
Copy link
Member

@okJiang okJiang commented Dec 29, 2025

No description provided.

Signed-off-by: okjiang <[email protected]>
Signed-off-by: okjiang <[email protected]>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 29, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign husharp for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from shonge December 29, 2025 08:08
@github-actions github-actions bot added the v2 for operator v2 label Dec 29, 2025
@ti-chi-bot ti-chi-bot bot added the size/XXL label Dec 29, 2025
@pingcap-cla-assistant
Copy link

pingcap-cla-assistant bot commented Dec 29, 2025

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2025

Codecov Report

❌ Patch coverage is 0.44379% with 673 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.10%. Comparing base (c01b1c9) to head (4a7292d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6635      +/-   ##
==========================================
- Coverage   39.33%   38.10%   -1.24%     
==========================================
  Files         351      367      +16     
  Lines       20665    21341     +676     
==========================================
+ Hits         8129     8132       +3     
- Misses      12536    13209     +673     
Flag Coverage Δ
unittest 38.10% <0.44%> (-1.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Hostname: coreutil.PodName[scope.ResourceManager](rm),
Subdomain: rm.Spec.Subdomain,
NodeSelector: rm.Spec.Topology,
Containers: []corev1.Container{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a readiness probe.

@liubog2008
Copy link
Member

add this component into the case in tests/e2e/suite/cluster/tls.go

Signed-off-by: okjiang <[email protected]>
Signed-off-by: okjiang <[email protected]>
Signed-off-by: okjiang <[email protected]>
Signed-off-by: okjiang <[email protected]>
Signed-off-by: okjiang <[email protected]>
Signed-off-by: okjiang <[email protected]>
Signed-off-by: okjiang <[email protected]>
Signed-off-by: okjiang <[email protected]>
UseSchedulingReadyAPI Feature = "UseSchedulingReadyAPI"
UseSchedulingReadyAPIStage FeatureStage = FeatureStageAlpha

// UseResourceManagerReadyAPI calls /health api to check readiness for resource manager pods.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to add a new feature gates for a new compnent

Signed-off-by: okjiang <[email protected]>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 7, 2026

@okJiang: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-e2e 4a7292d link true /test pull-e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XXL v2 for operator v2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants