Skip to content

fix(syncer): close metrics server for resource syncer#6664

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:mainfrom
liubog2008:liubo02/fix-syncer-port
Jan 19, 2026
Merged

fix(syncer): close metrics server for resource syncer#6664
ti-chi-bot[bot] merged 1 commit intopingcap:mainfrom
liubog2008:liubo02/fix-syncer-port

Conversation

@liubog2008
Copy link
Member

@liubog2008 liubog2008 commented Jan 19, 2026

8080 is conflict with ticdc's metrics port. Close metrics server until we actually need it.

Signed-off-by: liubo02 <liubo02@pingcap.com>
@github-actions github-actions bot added the v2 for operator v2 label Jan 19, 2026
@ti-chi-bot ti-chi-bot bot added the size/XS label Jan 19, 2026
@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 19, 2026
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 19, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-01-19 02:11:42.338579735 +0000 UTC m=+373529.952536590: ☑️ agreed by fgksgf.

@ti-chi-bot ti-chi-bot bot added the approved label Jan 19, 2026
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.31%. Comparing base (ccefca4) to head (3e9774c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6664   +/-   ##
=======================================
  Coverage   38.31%   38.31%           
=======================================
  Files         368      368           
  Lines       21422    21422           
=======================================
  Hits         8207     8207           
  Misses      13215    13215           
Flag Coverage Δ
unittest 38.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fgksgf, WangLe1321

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 55d3e84 into pingcap:main Jan 19, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments