Skip to content

tici: ensure config rolling update applies and use DNS flash.service_addr when TiCI enabled#6744

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:release-1.xfrom
3pointer:fix_tici_operator
Feb 27, 2026
Merged

tici: ensure config rolling update applies and use DNS flash.service_addr when TiCI enabled#6744
ti-chi-bot[bot] merged 2 commits intopingcap:release-1.xfrom
3pointer:fix_tici_operator

Conversation

@3pointer
Copy link
Contributor

Summary

This PR fixes two TiCI-related issues:

TiCI meta/worker config updates may not roll out to Pods even after ConfigMap changes.
When TiCI is enabled, TiFlash flash.service_addr could default to 0.0.0.0 (line 3930) instead of the headless DNS address required by TiCI reader.

Root Cause

TiCI StatefulSet reconcile path did not force rolling upgrade partition for pending updates, so Pod revision could remain old (currentRevision != updateRevision) with partition stuck.
TiFlash default flash.service_addr path did not switch to headless service DNS for TiCI-enabled clusters in all config builders.

Tests:

Add TestPrepareTiCIRollingUpgrade.
Update TiFlash service_addr tests to assert headless DNS for TiCI clusters.

@ti-chi-bot ti-chi-bot bot requested a review from shonge February 26, 2026 10:44
@ti-chi-bot ti-chi-bot bot added the size/L label Feb 26, 2026
@3pointer
Copy link
Contributor Author

/rebuild

@3pointer
Copy link
Contributor Author

/retest

@3pointer
Copy link
Contributor Author

/rebuild

1 similar comment
@3pointer
Copy link
Contributor Author

/rebuild

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csuzhangxc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 27, 2026
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 27, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-02-27 01:56:44.995818643 +0000 UTC m=+406477.510613262: ☑️ agreed by csuzhangxc.

@ti-chi-bot ti-chi-bot bot added the approved label Feb 27, 2026
@ti-chi-bot ti-chi-bot bot merged commit 339e333 into pingcap:release-1.x Feb 27, 2026
19 of 30 checks passed
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 27, 2026

@3pointer: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-e2e-kind-across-kubernetes d1ef512 link unknown /test pull-e2e-kind-across-kubernetes
pull-e2e-kind-tidbcluster d1ef512 link unknown /test pull-e2e-kind-tidbcluster

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants