tici: ensure config rolling update applies and use DNS flash.service_addr when TiCI enabled#6744
Conversation
|
/rebuild |
|
/retest |
|
/rebuild |
1 similar comment
|
/rebuild |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csuzhangxc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
@3pointer: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
This PR fixes two TiCI-related issues:
TiCI meta/worker config updates may not roll out to Pods even after ConfigMap changes.
When TiCI is enabled, TiFlash flash.service_addr could default to 0.0.0.0 (line 3930) instead of the headless DNS address required by TiCI reader.
Root Cause
TiCI StatefulSet reconcile path did not force rolling upgrade partition for pending updates, so Pod revision could remain old (currentRevision != updateRevision) with partition stuck.
TiFlash default flash.service_addr path did not switch to headless service DNS for TiCI-enabled clusters in all config builders.
Tests:
Add TestPrepareTiCIRollingUpgrade.
Update TiFlash service_addr tests to assert headless DNS for TiCI clusters.