tici: fix lost common prefix when apply config#6746
Merged
ti-chi-bot[bot] merged 1 commit intopingcap:release-1.xfrom Feb 27, 2026
Merged
tici: fix lost common prefix when apply config#6746ti-chi-bot[bot] merged 1 commit intopingcap:release-1.xfrom
ti-chi-bot[bot] merged 1 commit intopingcap:release-1.xfrom
Conversation
Contributor
|
Skipping CI for Draft Pull Request. |
csuzhangxc
approved these changes
Feb 27, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csuzhangxc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix TiCI config generation to correctly include s3.prefix for both meta and worker components. Previously, the generated TOML contained a prefix = "%s" placeholder but the fmt.Sprintf arguments did not include tc.Spec.TiCI.S3.Prefix, which could lead to missing/invalid s3.prefix in the rendered config. 
This PR also adds a unit test to ensure s3.prefix is present and the generated config is valid TOML.
What’s Changed
Code changes
Tests