Skip to content

tici: fix lost common prefix when apply config#6746

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:release-1.xfrom
3pointer:fix_tici_prefix
Feb 27, 2026
Merged

tici: fix lost common prefix when apply config#6746
ti-chi-bot[bot] merged 1 commit intopingcap:release-1.xfrom
3pointer:fix_tici_prefix

Conversation

@3pointer
Copy link
Contributor

@3pointer 3pointer commented Feb 27, 2026

Summary

Fix TiCI config generation to correctly include s3.prefix for both meta and worker components. Previously, the generated TOML contained a prefix = "%s" placeholder but the fmt.Sprintf arguments did not include tc.Spec.TiCI.S3.Prefix, which could lead to missing/invalid s3.prefix in the rendered config. 

This PR also adds a unit test to ensure s3.prefix is present and the generated config is valid TOML.

What’s Changed

Code changes

•	Include s3.Prefix in config rendering
•	Update the fmt.Sprintf argument lists so the generated TOML uses tc.Spec.TiCI.S3.Prefix for the prefix = "%s" field in:
•	buildTiCIMetaConfig(...)
•	buildTiCIWorkerConfig(...)  

Tests

•	Add TestBuildTiCIConfigIncludesS3Prefix

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 27, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot requested a review from shonge February 27, 2026 06:21
@ti-chi-bot ti-chi-bot bot added the size/M label Feb 27, 2026
@3pointer 3pointer marked this pull request as ready for review February 27, 2026 06:32
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csuzhangxc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 27, 2026
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 27, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-02-27 07:41:21.040642075 +0000 UTC m=+427153.555436684: ☑️ agreed by csuzhangxc.

@ti-chi-bot ti-chi-bot bot added the approved label Feb 27, 2026
@ti-chi-bot ti-chi-bot bot merged commit a0cc44a into pingcap:release-1.x Feb 27, 2026
9 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants